general/554: Allocated File Descriptors are not being freed after use.

[Robert Shady <ro...@mail.id.net>]

>Number:         554
>Category:       general
>Synopsis:       Allocated File Descriptors are not being freed after use.
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    apache (Apache HTTP Project)
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Tue May  6 20:30:01 1997
>Originator:     robert@mail.id.net
>Organization:
apache
>Release:        1.2b10
>Environment:
FreeBSD 2.2.1-RELEASE, however, all operating systems may be affected
under heavy load.
>Description:
In the file buff.c you have removed three lines of code that cause
detremental effects (server hanging because it's out of file
descriptors) after a period of time depending on your configuration.
The "note_cleanups_for_fd" lines apparently were accidentally removed
in the latest beta of your server software.  Adding these lines back
in appears to fix the problem.
>How-To-Repeat:
Run a heavily loaded webserver for 2-6 hours (depending on your
configuration) and things will start to die...
>Fix:
In file buff.c procedure 'bpushfd' add the following back in:
note_cleanups_for_fd(fb->pool, fb->fd);
if (fb->fd != fb->fd_in)
  note_cleanups_for_fd(fb->pool, fb->fd_in)%3
>Audit-Trail:
>Unformatted: