You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/01 04:11:12 UTC
[GitHub] [pulsar-client-go] cckellogg opened a new pull request #406: Add const client label to metrics
cckellogg opened a new pull request #406:
URL: https://github.com/apache/pulsar-client-go/pull/406
Add const client label to metrics so when metrics are added to other clients we can filter the metrics by client language.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] merlimat merged pull request #406: Add const client label to metrics
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #406:
URL: https://github.com/apache/pulsar-client-go/pull/406
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #406: Add const client label to metrics
Posted by GitBox <gi...@apache.org>.
cckellogg commented on a change in pull request #406:
URL: https://github.com/apache/pulsar-client-go/pull/406#discussion_r533061646
##########
File path: pulsar/internal/metrics.go
##########
@@ -0,0 +1,24 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package internal
+
+func constLabels() map[string]string {
+ return map[string]string{
+ "client": "go",
Review comment:
Eventually it might be good to add the client tag/commit sha too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org