You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Chi Zhang <ch...@gmail.com> on 2014/04/04 23:58:04 UTC

Review Request 20055: Modifed getHostName to use the correct error code.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20055/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos-git


Description
-------

see summary.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 42819ab 

Diff: https://reviews.apache.org/r/20055/diff/


Testing
-------


Thanks,

Chi Zhang

Re: Review Request 20055: Modifed getHostName to use the correct error code.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20055/#review39611
-----------------------------------------------------------


Patch looks great!

Reviews applied: [20055]

All tests passed.

- Mesos ReviewBot


On April 4, 2014, 9:58 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20055/
> -----------------------------------------------------------
> 
> (Updated April 4, 2014, 9:58 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 42819ab 
> 
> Diff: https://reviews.apache.org/r/20055/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 20055: Modifed getHostName to use the correct error code.

Posted by Dominic Hamon <dh...@twopensource.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20055/#review39612
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/20055/#comment72066>

    int err = ...
    
    no need to declare at the top of the method :)


- Dominic Hamon


On April 4, 2014, 2:58 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20055/
> -----------------------------------------------------------
> 
> (Updated April 4, 2014, 2:58 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 42819ab 
> 
> Diff: https://reviews.apache.org/r/20055/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 20055: Modifed getHostName to use the correct error code.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20055/#review39757
-----------------------------------------------------------


Bad patch!

Reviews applied: [20055]

Failed command: git apply --index 20055.patch

Error:
 error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:116
error: 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp: patch does not apply


- Mesos ReviewBot


On April 7, 2014, 7:12 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20055/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 7:12 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 42819ab 
> 
> Diff: https://reviews.apache.org/r/20055/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 20055: Modifed getHostName to use the correct error code.

Posted by Jie Yu <yu...@gmail.com>.

It has been submitted. Please mark it as submitted.


On Mon, Apr 7, 2014 at 12:26 PM, Jie Yu <yu...@gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20055/
>
> Ship it!
>
> Ship It!
>
>
> - Jie Yu
>
> On April 7th, 2014, 7:12 p.m. UTC, Chi Zhang wrote:
>   Review request for mesos.
> By Chi Zhang.
>
> *Updated April 7, 2014, 7:12 p.m.*
>  *Repository: * mesos-git
> Description
>
> see summary.
>
>   Diffs
>
>    - 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (42819ab)
>
> View Diff <https://reviews.apache.org/r/20055/diff/>
>

Re: Review Request 20055: Modifed getHostName to use the correct error code.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20055/#review39717
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On April 7, 2014, 7:12 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20055/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 7:12 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 42819ab 
> 
> Diff: https://reviews.apache.org/r/20055/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 20055: Modifed getHostName to use the correct error code.

Posted by Chi Zhang <ch...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20055/
-----------------------------------------------------------

(Updated April 7, 2014, 7:12 p.m.)


Review request for mesos.


Changes
-------

my C99 fingers :)


Repository: mesos-git


Description
-------

see summary.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 42819ab 

Diff: https://reviews.apache.org/r/20055/diff/


Testing
-------


Thanks,

Chi Zhang