You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Tim Ellison <t....@gmail.com> on 2009/11/25 14:40:51 UTC
[testing] tools failure (was: Re: [testing] M12 testing on Windows
x86)
On 24/Nov/2009 14:31, Tim Ellison wrote:
> Name Tests Errors Failures
> org.apache.harmony.tests.tools.javac 2 1 0
This is a failure caused by missing JAR files on the test classpath.
We used to have explicit code to find and load JAR files from the
tools.jar using reflection, and I changed that to put the JAR files on
the manifest's Class-Path:. I messed it up.
The classpath is set right for the command-line tool, but not for the
JUnit test.
I would like to fix it using this patch,
Index: working_jdktools/modules/jdktools/META-INF/MANIFEST.MF
===================================================================
--- working_jdktools/modules/jdktools/META-INF/MANIFEST.MF (revision 884022)
+++ working_jdktools/modules/jdktools/META-INF/MANIFEST.MF (working copy)
@@ -5,7 +5,10 @@
Implementation-Vendor: The Apache Software Foundation
Implementation-Vendor-Id: org.apache.harmony
Implementation-URL: http://harmony.apache.org
-Class-Path: ecj-3.4.2.jar,jdi.jar,jdimodel.jar,bcel-5.2.jar
+Class-Path: com.ibm.icu.base_3.6.1.v20070417.jar
+ ecj-3.4.2.jar
+ jdimodel.jar
+ jdtstub.jar
Bundle-ManifestVersion: 2
Bundle-Name: Harmony Tools
Bundle-SymbolicName: org.apache.harmony.tools
Please could somebody review and approve this change.
Regards,
Tim
Re: [testing] tools failure
Posted by Tim Ellison <t....@gmail.com>.
On 25/Nov/2009 19:40, Mark Hindess wrote:
> In message <4B...@gmail.com>, Tim Ellison writes:
>> On 24/Nov/2009 14:31, Tim Ellison wrote:
>>> Name Tests Errors Failures
>>> org.apache.harmony.tests.tools.javac 2 1 0
>> This is a failure caused by missing JAR files on the test classpath.
>>
>> We used to have explicit code to find and load JAR files from the
>> tools.jar using reflection, and I changed that to put the JAR files on
>> the manifest's Class-Path:. I messed it up.
>>
>> The classpath is set right for the command-line tool, but not for the
>> JUnit test.
>>
>> I would like to fix it using this patch,
>>
>> Index: working_jdktools/modules/jdktools/META-INF/MANIFEST.MF
>> ===================================================================
>> --- working_jdktools/modules/jdktools/META-INF/MANIFEST.MF (revision 88402
>> 2)
>> +++ working_jdktools/modules/jdktools/META-INF/MANIFEST.MF (working copy)
>> @@ -5,7 +5,10 @@
>> Implementation-Vendor: The Apache Software Foundation
>> Implementation-Vendor-Id: org.apache.harmony
>> Implementation-URL: http://harmony.apache.org
>> -Class-Path: ecj-3.4.2.jar,jdi.jar,jdimodel.jar,bcel-5.2.jar
>> +Class-Path: com.ibm.icu.base_3.6.1.v20070417.jar
>> + ecj-3.4.2.jar
>> + jdimodel.jar
>> + jdtstub.jar
>> Bundle-ManifestVersion: 2
>> Bundle-Name: Harmony Tools
>> Bundle-SymbolicName: org.apache.harmony.tools
>
>
> This fixes the problem for me. So I am +1 for applying it.
Thanks, fixed in r884286.
I'm still testing but I don't think there are any failures left that
will block the milestone. I'll post more results tomorrow.
Regards,
Tim
Re: [testing] tools failure (was: Re: [testing] M12 testing on Windows x86)
Posted by Mark Hindess <ma...@googlemail.com>.
In message <4B...@gmail.com>, Tim Ellison writes:
>
> On 24/Nov/2009 14:31, Tim Ellison wrote:
> > Name Tests Errors Failures
> > org.apache.harmony.tests.tools.javac 2 1 0
>
> This is a failure caused by missing JAR files on the test classpath.
>
> We used to have explicit code to find and load JAR files from the
> tools.jar using reflection, and I changed that to put the JAR files on
> the manifest's Class-Path:. I messed it up.
>
> The classpath is set right for the command-line tool, but not for the
> JUnit test.
>
> I would like to fix it using this patch,
>
> Index: working_jdktools/modules/jdktools/META-INF/MANIFEST.MF
> ===================================================================
> --- working_jdktools/modules/jdktools/META-INF/MANIFEST.MF (revision 88402
> 2)
> +++ working_jdktools/modules/jdktools/META-INF/MANIFEST.MF (working copy)
> @@ -5,7 +5,10 @@
> Implementation-Vendor: The Apache Software Foundation
> Implementation-Vendor-Id: org.apache.harmony
> Implementation-URL: http://harmony.apache.org
> -Class-Path: ecj-3.4.2.jar,jdi.jar,jdimodel.jar,bcel-5.2.jar
> +Class-Path: com.ibm.icu.base_3.6.1.v20070417.jar
> + ecj-3.4.2.jar
> + jdimodel.jar
> + jdtstub.jar
> Bundle-ManifestVersion: 2
> Bundle-Name: Harmony Tools
> Bundle-SymbolicName: org.apache.harmony.tools
This fixes the problem for me. So I am +1 for applying it.
-Mark.