[GitHub] [iceberg] rdblue commented on a change in pull request #2239: Core: Support unpartitioned specs in SortOrderUtil

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2239:
URL: https://github.com/apache/iceberg/pull/2239#discussion_r580695680



##########
File path: core/src/main/java/org/apache/iceberg/util/SortOrderUtil.java
##########
@@ -37,16 +37,14 @@ private SortOrderUtil() {
   }
 
   public static SortOrder buildSortOrder(Table table) {
-    return buildSortOrder(table.spec(), table.sortOrder());
+    return buildSortOrder(table.schema(), table.spec(), table.sortOrder());

Review comment:
       How was this failing before? The unpartitioned spec isn't usually returned by a table once it has been written and loaded from disk, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org