[GitHub] [incubator-dubbo] CrazyHZM opened pull request #3597: merge RestProtocolTest.java

["CrazyHZM (GitHub)" <gi...@apache.org>]

## What is the purpose of the change

XXXXX

## Brief changelog

XXXXX

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3597 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 closed pull request #3597: merge RestProtocolTest.java

["ralf0131 (GitHub)" <gi...@apache.org>]

[ pull request closed by ralf0131 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3597 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] htynkn commented on issue #3597: merge RestProtocolTest.java

["htynkn (GitHub)" <gi...@apache.org>]

what's the purpose of this PR? add a new unit test?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3597 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on issue #3597: merge RestProtocolTest.java

["ralf0131 (GitHub)" <gi...@apache.org>]

Hi, next time please clearly describe your pull request by filling in the XXXX, which will give the reviewer a better understanding of what you are trying to do...

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3597 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] CrazyHZM commented on issue #3597: merge RestProtocolTest.java

["CrazyHZM (GitHub)" <gi...@apache.org>]

> what's the purpose of this PR? add a new unit test?


Merged two RestProtocolTest.java and removed the extra test class

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3597 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3597: merge RestProtocolTest.java

["khanimteyaz (GitHub)" <gi...@apache.org>]

would you care to split the UT in more logic unit e.g.

```
@Test
public void testServerIsCalled() {
   URL url = URL.valueOf("rest://127.0.0.1:5342/rest/say?version=1.0.0");
        DemoServiceImpl server = new DemoServiceImpl();
        ProviderModel providerModel = new ProviderModel(url.getServiceKey(), server, DemoService.class);
        ApplicationModel.initProviderModel(url.getServiceKey(), providerModel);

        Exporter<DemoService> exporter = protocol.export(proxy.getInvoker(server, DemoService.class, url));
        Invoker<DemoService> invoker = protocol.refer(DemoService.class, url);
}
```

```
@Test
public void testRestProtocolReturnResult() {
   URL url = URL.valueOf("rest://127.0.0.1:5342/rest/say?version=1.0.0");
        DemoServiceImpl server = new DemoServiceImpl();
        ProviderModel providerModel = new ProviderModel(url.getServiceKey(), server, DemoService.class);
        ApplicationModel.initProviderModel(url.getServiceKey(), providerModel);

        Exporter<DemoService> exporter = protocol.export(proxy.getInvoker(server, DemoService.class, url));
        Invoker<DemoService> invoker = protocol.refer(DemoService.class, url);
       DemoService client = proxy.getProxy(invoker);
        String result = client.sayHello("haha");
        Assertions.assertTrue(server.isCalled());
        Assertions.assertEquals("Hello, haha", result);
        invoker.destroy();
        exporter.unexport();
}
```

To me in the suggested way, if anything breaks, looking at UT we can get more closer to place where it has break. What do you say?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3597 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] CrazyHZM commented on pull request #3597: merge RestProtocolTest.java

["CrazyHZM (GitHub)" <gi...@apache.org>]

I think the impact is not great. The testRestProtocol itself is to detect whether the Rest Protocol is successfully used.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3597 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org