You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mappjzc (via GitHub)" <gi...@apache.org> on 2023/05/04 14:07:14 UTC

[GitHub] [incubator-devlake] mappjzc opened a new pull request, #5092: Zentao fix

mappjzc opened a new pull request, #5092:
URL: https://github.com/apache/incubator-devlake/pull/5092

   ### Summary
   fix the json lowcase error.
   fix the project and product ignore error.
   
   
   ### Screenshots
   ![image](https://user-images.githubusercontent.com/2921251/236232262-75059351-836d-4985-aa14-c3cb2d66e65c.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] mappjzc merged pull request #5092: Zentao fix

Posted by "mappjzc (via GitHub)" <gi...@apache.org>.
mappjzc merged PR #5092:
URL: https://github.com/apache/incubator-devlake/pull/5092


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] likyh commented on a diff in pull request #5092: Zentao fix

Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh commented on code in PR #5092:
URL: https://github.com/apache/incubator-devlake/pull/5092#discussion_r1185640799


##########
backend/plugins/zentao/models/product.go:
##########
@@ -19,53 +19,56 @@ package models
 
 import (
 	"fmt"
+
 	"github.com/apache/incubator-devlake/core/models/common"
 	"github.com/apache/incubator-devlake/core/plugin"
 	helper "github.com/apache/incubator-devlake/helpers/pluginhelper/api"
 )
 
 type ZentaoProductRes struct {
-	ID             int64               `json:"id"`
-	Program        int                 `json:"program"`
-	Name           string              `json:"name"`
-	Code           string              `json:"code"`
-	Bind           string              `json:"bind"`
-	Line           int                 `json:"line"`
-	Type           string              `json:"type"`
-	Status         string              `json:"status"`
-	SubStatus      string              `json:"subStatus"`
-	Description    string              `json:"desc"`
-	PO             *ZentaoAccount      `json:"PO"`
-	QD             *ZentaoAccount      `json:"QD"`
-	RD             *ZentaoAccount      `json:"RD"`
-	Feedback       interface{}         `json:"feedback"`
-	Acl            string              `json:"acl"`
-	Whitelist      []interface{}       `json:"whitelist"`
-	Reviewer       string              `json:"reviewer"`
-	CreatedBy      *ZentaoAccount      `json:"createdBy"`
-	CreatedDate    *helper.Iso8601Time `json:"createdDate"`
-	CreatedVersion string              `json:"createdVersion"`
-	OrderIn        int                 `json:"order"`
-	Vision         string              `json:"vision"`
-	Deleted        string              `json:"deleted"`
+	ID             int64               `json:"id" mapstructure:"id"`
+	Program        int                 `json:"program" mapstructure:"program"`
+	Name           string              `json:"name" mapstructure:"name"`
+	Code           string              `json:"code" mapstructure:"code"`
+	Bind           string              `json:"bind" mapstructure:"bind"`
+	Line           int                 `json:"line" mapstructure:"line"`
+	Type           string              `json:"type" mapstructure:"type"`
+	Status         string              `json:"status" mapstructure:"status"`
+	SubStatus      string              `json:"subStatus" mapstructure:"subStatus"`
+	Description    string              `json:"desc" mapstructure:"desc"`
+	PO             *ZentaoAccount      `json:"po" mapstructure:"po"`
+	QD             *ZentaoAccount      `json:"qd" mapstructure:"qd"`
+	RD             *ZentaoAccount      `json:"rd" mapstructure:"rd"`
+	Feedback       interface{}         `json:"feedback" mapstructure:"feedback"`
+	Acl            string              `json:"acl" mapstructure:"acl"`
+	Whitelist      []interface{}       `json:"whitelist" mapstructure:"whitelist"`
+	Reviewer       string              `json:"reviewer" mapstructure:"reviewer"`
+	CreatedBy      *ZentaoAccount      `json:"createdBy" mapstructure:"createdBy"`
+	CreatedDate    *helper.Iso8601Time `json:"createdDate" mapstructure:"createdDate"`
+	CreatedVersion string              `json:"createdVersion" mapstructure:"createdVersion"`
+	OrderIn        int                 `json:"order" mapstructure:"order"`
+	Vision         string              `json:"vision" mapstructure:"vision"`
+	Deleted        string              `json:"deleted" mapstructure:"deleted"`
 	Stories        struct {
-		Active    int `json:"active"`
-		Reviewing int `json:"reviewing"`
+		Active    int `json:"active" mapstructure:"active"`
+		Reviewing int `json:"reviewing" mapstructure:"reviewing"`
 		int       `json:""`
-		Draft     int `json:"draft"`
-		Closed    int `json:"closed"`
-		Changing  int `json:"changing"`
+		Draft     int `json:"draft" mapstructure:"draft"`
+		Closed    int `json:"closed" mapstructure:"closed"`
+		Changing  int `json:"changing" mapstructure:"changing"`
 	} `json:"stories"`
-	Plans      int     `json:"plans"`
-	Releases   int     `json:"releases"`
-	Builds     int     `json:"builds"`
-	Cases      int     `json:"cases"`
-	Projects   int     `json:"projects"`
-	Executions int     `json:"executions"`
-	Bugs       int     `json:"bugs"`
-	Docs       int     `json:"docs"`
-	Progress   float64 `json:"progress"`
-	CaseReview bool    `json:"caseReview"`
+	Plans      int     `json:"plans" mapstructure:"plans"`
+	Releases   int     `json:"releases" mapstructure:"releases"`
+	Builds     int     `json:"builds" mapstructure:"builds"`
+	Cases      int     `json:"cases" mapstructure:"cases"`
+	Projects   int     `json:"projects" mapstructure:"projects"`
+	Executions int     `json:"executions" mapstructure:"executions"`
+	Bugs       int     `json:"bugs" mapstructure:"bugs"`
+	Docs       int     `json:"docs" mapstructure:"docs"`
+	Progress   float64 `json:"progress" mapstructure:"progress"`
+	CaseReview bool    `json:"caseReview" mapstructure:"caseReview"`
+
+	TransformationRuleId uint64 `json:"transformationRuleId" gorm:"-"`

Review Comment:
   zentao use api.NoTransformation. Why add trId for scope?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org