You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "James Dyer (Created) (JIRA)" <ji...@apache.org> on 2012/02/27 22:51:48 UTC
[jira] [Created] (SOLR-3168) "numberToKeep" backups doesn't ever
keep more than 1
"numberToKeep" backups doesn't ever keep more than 1
----------------------------------------------------
Key: SOLR-3168
URL: https://issues.apache.org/jira/browse/SOLR-3168
Project: Solr
Issue Type: Bug
Components: replication (java)
Affects Versions: 3.5, 4.0
Reporter: James Dyer
Assignee: James Dyer
Priority: Trivial
Fix For: 3.6, 4.0
Attachments: SOLR-3168.patch
On SOLR-2578, Neil Hooey pointed out a silly mistake in SnapShooter.java in that I forgot to increment a counter variable in the case the user wants to keep more than 1 backup.
I will attach a patch for this 1-line fix. I do not intend to amend the unit test as this fix is easy to understand. Also, the test case is already very complex and long-running.
I will commit shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3168) "numberToKeep" backups doesn't ever
keep more than 1
Posted by "James Dyer (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer resolved SOLR-3168.
------------------------------
Resolution: Fixed
Committed r1294703 (Trunk) & r1294718 (3.x).
Thanks, Neil.
> "numberToKeep" backups doesn't ever keep more than 1
> ----------------------------------------------------
>
> Key: SOLR-3168
> URL: https://issues.apache.org/jira/browse/SOLR-3168
> Project: Solr
> Issue Type: Bug
> Components: replication (java)
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3168.patch
>
>
> On SOLR-2578, Neil Hooey pointed out a silly mistake in SnapShooter.java in that I forgot to increment a counter variable in the case the user wants to keep more than 1 backup.
> I will attach a patch for this 1-line fix. I do not intend to amend the unit test as this fix is easy to understand. Also, the test case is already very complex and long-running.
> I will commit shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3168) "numberToKeep" backups doesn't ever
keep more than 1
Posted by "James Dyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-3168:
-----------------------------
Attachment: SOLR-3168.patch
> "numberToKeep" backups doesn't ever keep more than 1
> ----------------------------------------------------
>
> Key: SOLR-3168
> URL: https://issues.apache.org/jira/browse/SOLR-3168
> Project: Solr
> Issue Type: Bug
> Components: replication (java)
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3168.patch
>
>
> On SOLR-2578, Neil Hooey pointed out a silly mistake in SnapShooter.java in that I forgot to increment a counter variable in the case the user wants to keep more than 1 backup.
> I will attach a patch for this 1-line fix. I do not intend to amend the unit test as this fix is easy to understand. Also, the test case is already very complex and long-running.
> I will commit shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org