You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samoa.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/01/27 14:06:34 UTC

[jira] [Commented] (SAMOA-6) Reformat codebase and add formatting guidelines

    [ https://issues.apache.org/jira/browse/SAMOA-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293475#comment-14293475 ] 

ASF GitHub Bot commented on SAMOA-6:
------------------------------------

GitHub user matthieumorel opened a pull request:

    https://github.com/apache/incubator-samoa/pull/2

    SAMOA-6 : code formatting

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matthieumorel/incubator-samoa SAMOA-6

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-samoa/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2
    
----
commit 5af84c1b04a6445449019f9295f91f1002b8a1c3
Author: Matthieu Morel <mm...@apache.org>
Date:   2015-01-27T12:54:57Z

    Add eclipse formatting reference file

commit 23a35dbeb6c991b66293cc8138313b7651c831a2
Author: Matthieu Morel <mm...@apache.org>
Date:   2015-01-27T12:56:17Z

    Format java source files according to the eclipse-format.xml standard
    - spaces, no tabs
    - indent size = 2 spaces
    - line wrap at 120

commit 6539c9138d33993551b0a6738784da6eda7b6b84
Author: Matthieu Morel <mm...@apache.org>
Date:   2015-01-27T12:57:24Z

    Properly indent xml files. Indentation set to 2 spaces.

----


> Reformat codebase and add formatting guidelines
> -----------------------------------------------
>
>                 Key: SAMOA-6
>                 URL: https://issues.apache.org/jira/browse/SAMOA-6
>             Project: SAMOA
>          Issue Type: Task
>          Components: SAMOA-API, SAMOA-instances, SAMOA-Local, SAMOA-S4, SAMOA-Samza, SAMOA-Storm, SAMOA-Threads
>            Reporter: Gianmarco De Francisci Morales
>
> Migrating issue 118 from GitHub https://github.com/yahoo/samoa/issues/118
> We need to agree on formatting guidelines, write them down, and reformat the whole codebase in a single commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)