You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/23 17:31:44 UTC
[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5589: net/tcp(buffered): retransmit only one the earliest not acknowledged segment
a-lunev commented on a change in pull request #5589:
URL: https://github.com/apache/incubator-nuttx/pull/5589#discussion_r813141667
##########
File path: net/tcp/tcp_send_buffered.c
##########
@@ -796,7 +741,7 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,
*/
if ((conn->tcpstateflags & TCP_ESTABLISHED) &&
- (flags & (TCP_POLL | TCP_REXMIT)) &&
+ (flags & TCP_POLL) &&
Review comment:
Done.
##########
File path: net/tcp/tcp_send_buffered.c
##########
@@ -796,7 +741,7 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,
*/
if ((conn->tcpstateflags & TCP_ESTABLISHED) &&
Review comment:
Done.
##########
File path: net/tcp/tcp_send_buffered.c
##########
@@ -796,7 +741,7 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,
*/
if ((conn->tcpstateflags & TCP_ESTABLISHED) &&
- (flags & (TCP_POLL | TCP_REXMIT)) &&
+ (flags & TCP_POLL) &&
!(sq_empty(&conn->write_q)) &&
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org