You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/11/20 21:27:47 UTC
[PR] HDDS-9512. Datanode in ozone share a same port with datanode in HDFS. [ozone]
adoroszlai opened a new pull request, #5639:
URL: https://github.com/apache/ozone/pull/5639
## What changes were proposed in this pull request?
Change Ozone Datanode client port default value from 9864 to 19864. This port was added since the last release (1.3.0) to support dynamic reconfiguration protocol, but it conflicts with HDFS Datanode web port. Thus it makes sense to change it before the conflicting port gets into any Ozone release.
https://issues.apache.org/jira/browse/HDDS-9512
## How was this patch tested?
Tested the port in `ozone` compose environment:
```
$ ozone admin reconfig --address 192.168.80.9:19864 properties
DN: Node [192.168.80.9:19864] Reconfigurable properties:
hdds.datanode.block.delete.threads.max
hdds.datanode.block.deleting.limit.per.interval
ozone.block.deleting.service.workers
```
CI:
https://github.com/adoroszlai/ozone/actions/runs/6934881675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9512. Datanode in ozone share a same port with datanode in HDFS. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5639:
URL: https://github.com/apache/ozone/pull/5639#issuecomment-1820283431
> The IntelliJ application also uses port 19864
Thanks @xichen01 for pointing that out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9512. Datanode client port conflicts with HDFS Datanode web port [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5639:
URL: https://github.com/apache/ozone/pull/5639#issuecomment-1824071531
Thanks @ChenSammi, @xichen01 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9512. Datanode in ozone share a same port with datanode in HDFS. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5639:
URL: https://github.com/apache/ozone/pull/5639#issuecomment-1820423749
> can we also use a non-ephemeral port here?
According to [Wikipedia](https://en.wikipedia.org/wiki/Ephemeral_port) different systems use different ranges for ephemeral ports. Considering the ranges "used by many Linux kernels" and Solaris / AIX, 19864 is not an ephemeral port. (RFC 6335 and IANA suggest a smaller range than that.) Considering some other range definitions, mostly related to Windows, all Ozone ports are ephemeral, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9512. Datanode in ozone share a same port with datanode in HDFS. [ozone]
Posted by "xichen01 (via GitHub)" <gi...@apache.org>.
xichen01 commented on PR #5639:
URL: https://github.com/apache/ozone/pull/5639#issuecomment-1820136883
The IntelliJ application also uses port 19864, which may cause the IntelliJ Ozone to fail to start due to a port conflict.
https://github.com/apache/ozone/blob/945e8bfdcfe0be1fecbca3716d41305c4ae23d00/hadoop-ozone/dev-support/intellij/runConfigurations/Datanode2.xml#L21C398-L21C398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9512. Datanode in ozone share a same port with datanode in HDFS. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5639:
URL: https://github.com/apache/ozone/pull/5639#issuecomment-1819832394
@xichen01 can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9512. Datanode client port conflicts with HDFS Datanode web port [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5639:
URL: https://github.com/apache/ozone/pull/5639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9512. Datanode in ozone share a same port with datanode in HDFS. [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #5639:
URL: https://github.com/apache/ozone/pull/5639#issuecomment-1820402002
@adoroszlai , thanks for working on this. HDFS(HDFS-9427) once changed from default ephemeral to non-ephemeral ports, can we also use a non-ephemeral port here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9512. Datanode client port conflicts with HDFS Datanode web port [ozone]
Posted by "xichen01 (via GitHub)" <gi...@apache.org>.
xichen01 commented on PR #5639:
URL: https://github.com/apache/ozone/pull/5639#issuecomment-1823958999
LGTM+1, Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9512. Datanode in ozone share a same port with datanode in HDFS. [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #5639:
URL: https://github.com/apache/ozone/pull/5639#issuecomment-1822015511
> > can we also use a non-ephemeral port here?
>
> According to [Wikipedia](https://en.wikipedia.org/wiki/Ephemeral_port) different systems use different ranges for ephemeral ports. Considering the ranges "used by many Linux kernels" and Solaris / AIX, 19864 is not an ephemeral port. (RFC 6335 and IANA suggest a smaller range than that.) Considering some other range definitions, mostly related to Windows, all Ozone ports are ephemeral, too.
Okay. The overall change looks good. And I tested it locally with intellij.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org