You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/21 15:37:42 UTC

[GitHub] [superset] pkdotson commented on pull request #15777: chore: Select component refactoring - FilterControl - Iteration 5

pkdotson commented on pull request #15777:
URL: https://github.com/apache/superset/pull/15777#issuecomment-924108711


   The code lgtm. But in regards to clearing the fields like @michael-s-molina suggested would be nice but to be fair it doesn't currently do that on master so I think that could be done as a follow up as that might require a little more refactoring work?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org