You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/05 10:08:45 UTC
[GitHub] [superset] zhaoyongjie commented on a change in pull request #15186: fix(dashboard-list): change name of dashboard is not reflected instantly
zhaoyongjie commented on a change in pull request #15186:
URL: https://github.com/apache/superset/pull/15186#discussion_r663809548
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -157,7 +157,7 @@ function DashboardList(props: DashboardListProps) {
({ json = {} }) => {
setDashboards(
dashboards.map(dashboard => {
- if (dashboard.id === json.id) {
+ if (dashboard.id === json?.result.id) {
Review comment:
I have added `changed_on_delta_humanized` field in the RESTful response.
https://github.com/apache/superset/pull/15542
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -157,7 +157,7 @@ function DashboardList(props: DashboardListProps) {
({ json = {} }) => {
setDashboards(
dashboards.map(dashboard => {
- if (dashboard.id === json.id) {
+ if (dashboard.id === json?.result.id) {
Review comment:
I have added `changed_on_delta_humanized` field in the RESTful response.
link to: https://github.com/apache/superset/pull/15542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org