[GitHub] [arrow-datafusion] alamb opened a new pull request, #5673: minor: reduce replication in `date_bin` implementation

["alamb (via GitHub)" <gi...@apache.org>]

alamb opened a new pull request, #5673:
URL: https://github.com/apache/arrow-datafusion/pull/5673

   # Which issue does this PR close?
   
   re https://github.com/apache/arrow-datafusion/pull/5643 and https://github.com/apache/arrow-datafusion/issues/5641
   
   # Rationale for this change
   
   I saw a way to reduce some code duplication introduced in https://github.com/apache/arrow-datafusion/pull/5643 but felt it would not be fair to @Weijun-H  to go back and forth more on that one. 
   
   # What changes are included in this PR?
   refactor the `date_bin` implementation to have a single implementation for 2 and 3 argument forms
   
   # Are these changes tested?
   Existing coverage
   
   # Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #5673: minor: reduce replication in `date_bin` implementation

["alamb (via GitHub)" <gi...@apache.org>]

alamb merged PR #5673:
URL: https://github.com/apache/arrow-datafusion/pull/5673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org