You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vatsrahul1001 (via GitHub)" <gi...@apache.org> on 2024/12/05 11:50:54 UTC
[PR] Remove deprecations from Slack Provider [airflow]
vatsrahul1001 opened a new pull request, #44693:
URL: https://github.com/apache/airflow/pull/44693
related: https://github.com/apache/airflow/issues/44559
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecations from Slack Provider [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #44693:
URL: https://github.com/apache/airflow/pull/44693#discussion_r1872836268
##########
providers/src/airflow/providers/slack/CHANGELOG.rst:
##########
@@ -27,6 +27,20 @@
Changelog
---------
+main
+....
+
+.. warning::
+ All deprecated classes, parameters and features have been removed from the slack provider package.
+ The following breaking changes were introduced:
+
+ * ``Removed deprecated SqlToSlackOperator. Use SqlToSlackWebhookOperator instead.``
+ * ``Removed deprecated send_file method from hooks. Use send_file_v2 or send_file_v1_to_v2 instead.``
+ * ``Removed deprecated module lack_notifier.py. Use airflow.providers.slack.notifications.slack instead.``
+ * ``Define method parameter as empty string or None is deprecated.``
+ * ``Removed deprecated parameter slack_conn_id from SqlToSlackWebhookOperator. Use slack_webhook_conn_id instead.``
Review Comment:
```suggestion
* Removed deprecated ``SqlToSlackOperator``. Use ``SqlToSlackWebhookOperator`` instead.
* Removed deprecated ``send_file`` method from hooks. Use ``send_file_v2`` or ``send_file_v1_to_v2`` instead.
* Removed deprecated module lack_notifier.py. Use ``airflow.providers.slack.notifications.slack`` instead.
* Define method parameter as empty string or None is deprecated.
* Removed deprecated parameter ``slack_conn_id`` from ``SqlToSlackWebhookOperator``. Use ``slack_webhook_conn_id`` instead.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove deprecations from Slack Provider [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #44693:
URL: https://github.com/apache/airflow/pull/44693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org