[royale-compiler] branch develop updated: RenamePropertiesWithModuleSupport: break should have been continue

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git


The following commit(s) were added to refs/heads/develop by this push:
     new f23844f  RenamePropertiesWithModuleSupport: break should have been continue
f23844f is described below

commit f23844ff3001d54df9cde3e93678d2f3520740cc
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Tue Sep 15 14:28:16 2020 -0700

    RenamePropertiesWithModuleSupport: break should have been continue
---
 .../com/google/javascript/jscomp/RenamePropertiesWithModuleSupport.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compiler-jx/src/main/java/com/google/javascript/jscomp/RenamePropertiesWithModuleSupport.java b/compiler-jx/src/main/java/com/google/javascript/jscomp/RenamePropertiesWithModuleSupport.java
index 44f1b26..c6e6746 100644
--- a/compiler-jx/src/main/java/com/google/javascript/jscomp/RenamePropertiesWithModuleSupport.java
+++ b/compiler-jx/src/main/java/com/google/javascript/jscomp/RenamePropertiesWithModuleSupport.java
@@ -451,7 +451,7 @@ class RenamePropertiesWithModuleSupport implements CompilerPass {
                   if (compiler.getCodingConvention().blockRenamingForProperty(memberDefName)) {
                     externedNames.add(fnName.getString());
                   } else if(propertyNamesToKeep.contains(memberDefName)) {
-                      break;
+                      continue;
                   } else if (memberDefName.equals("constructor")
                       || memberDefName.equals("superClass_")) {
                     // TODO (simarora) is there a better way to identify these externs?