You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/12 17:05:31 UTC
[GitHub] [airflow] ashb opened a new pull request #12314: Fix prod image build
ashb opened a new pull request #12314:
URL: https://github.com/apache/airflow/pull/12314
Running `setup.py` was failing with a KeyError: yandex, meaning #12265
didn't quite fix it.
It is unclear to at this point why CI passed on that PR.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12314: Fix prod image build
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12314:
URL: https://github.com/apache/airflow/pull/12314#issuecomment-726237026
It's quite clear why:
`pip install --user 'https://github.com/apache/airflow/archive/master.tar.gz#egg=apache-airflow[async,aws,azure,celery,dask,elasticsearch,gcp,kubernetes,mysql,postgres,redis,slack,ssh,statsd,virtualenv]' --constraint https://raw.githubusercontent.com/apache/airflow/constraints-master/constraints-3.6.txt`
Takes the master version from apache/airflow repo (in order to get faster builds when setup.py changes).
By definition, when PR is run, this change is not yet in master, so it will start failing only after PR is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #12314: Fix prod image build
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #12314:
URL: https://github.com/apache/airflow/pull/12314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12314: Fix prod image build
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12314:
URL: https://github.com/apache/airflow/pull/12314#issuecomment-726238138
And it's pure optimization. Without this line any change in setup.py causes + 5-10 minutes on rebuilds of the image - for example during Kubernetes testing. So while it might cause very occasional breaks like that, I think overall it's worth it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12314: Fix prod image build
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12314:
URL: https://github.com/apache/airflow/pull/12314#issuecomment-726238138
And it's pure optimization. Without this line any change in setup.py causes + 5-10 minutes on rebuilds of the image - for example during Kubernetes testing. So while it might cause very occasional breaks like that, I think overall it's worth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org