You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/27 14:40:32 UTC
[GitHub] [arrow] ritchie46 opened a new pull request #9337: fix build for conditional compilation of features 'simd + avx512'
ritchie46 opened a new pull request #9337:
URL: https://github.com/apache/arrow/pull/9337
This fixes conditional compilation for `simd` and `avx512`. Currently compilation for both fails:
```
error[E0428]: the name `buffer_bin_and` is defined multiple times
--> arrow/src/buffer.rs:472:1
|
414 | / pub(super) fn buffer_bin_and(
415 | | left: &Buffer,
416 | | left_offset_in_bits: usize,
417 | | right: &Buffer,
... |
468 | | }
469 | | }
| |_- previous definition of the value `buffer_bin_and` here
...
472 | / pub(super) fn buffer_bin_and(
473 | | left: &Buffer,
474 | | left_offset_in_bits: usize,
475 | | right: &Buffer,
... |
501 | | }
502 | | }
| |_^ `buffer_bin_and` redefined here
|
= note: `buffer_bin_and` must be defined only once in the value namespace of this module
error[E0428]: the name `buffer_bin_or` is defined multiple times
--> arrow/src/buffer.rs:583:1
|
525 | / pub(super) fn buffer_bin_or(
526 | | left: &Buffer,
527 | | left_offset_in_bits: usize,
528 | | right: &Buffer,
... |
579 | | }
580 | | }
| |_- previous definition of the value `buffer_bin_or` here
...
583 | / pub(super) fn buffer_bin_or(
584 | | left: &Buffer,
585 | | left_offset_in_bits: usize,
586 | | right: &Buffer,
... |
612 | | }
613 | | }
| |_^ `buffer_bin_or` redefined here
|
= note: `buffer_bin_or` must be defined only once in the value namespace of this module
```
This PR is tested on:
`$ cargo c --features "simd"`
`$ cargo c --features "simd avx512"`
`$ cargo c --features "avx512"`
Maybe a check like used in [cargo hack](https://github.com/taiki-e/cargo-hack) can be added to the CI pipeline? This checks compilation for multiple feature combinations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9337: [Arrow]-11387: [Rust] fix build for conditional compilation of features 'simd + avx512'
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9337:
URL: https://github.com/apache/arrow/pull/9337#issuecomment-769005979
On my machine, specifically, I tested in this manner:
```
# works fine
cargo +nightly build --features=simd
# works fine
cargo +nightly build --features=avx512
# fails without this PR, works with this PR:
cargo +nightly build --features=avx512,simd
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ChristianBeilschmidt commented on pull request #9337: [Rust] fix build for conditional compilation of features 'simd + avx512'
Posted by GitBox <gi...@apache.org>.
ChristianBeilschmidt commented on pull request #9337:
URL: https://github.com/apache/arrow/pull/9337#issuecomment-768825835
> Thanks for opening a pull request!
>
> Could you open an issue for this pull request on JIRA?
> https://issues.apache.org/jira/browse/ARROW
>
> Then could you also rename pull request title in the following format?
>
> ```
> ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
> ```
>
> See also:
>
> * [Other pull requests](https://github.com/apache/arrow/pulls/)
>
> * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
@ritchie46 I guess you need to prepend your Jira Issue to your PR-title:
https://issues.apache.org/jira/browse/ARROW-11387
So, I guess
ARROW-11387: [Rust] fix build for conditional compilation of features 'simd + avx512'
And thank you for the PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9337: ARROW-11387: [Rust] fix build for conditional compilation of features 'simd + avx512'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9337:
URL: https://github.com/apache/arrow/pull/9337#issuecomment-769384878
https://issues.apache.org/jira/browse/ARROW-11387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #9337: ARROW-11387: [Rust] fix build for conditional compilation of features 'simd + avx512'
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #9337:
URL: https://github.com/apache/arrow/pull/9337#issuecomment-770050294
For any JIRA issues that we want to include in a patch release, we should update the release version to include both `3.0.0` and `3.0.1` so that we have the list of candidates to use if we create a patch release as the first step
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #9337: ARROW-11387: [Rust] fix build for conditional compilation of features 'simd + avx512'
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9337:
URL: https://github.com/apache/arrow/pull/9337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9337: fix build for conditional compilation of features 'simd + avx512'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9337:
URL: https://github.com/apache/arrow/pull/9337#issuecomment-768330721
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vertexclique commented on pull request #9337: [Arrow]-11387: [Rust] fix build for conditional compilation of features 'simd + avx512'
Posted by GitBox <gi...@apache.org>.
vertexclique commented on pull request #9337:
URL: https://github.com/apache/arrow/pull/9337#issuecomment-769012377
I think we've talked about this mutual exclusivity of features here: https://github.com/apache/arrow/pull/8665#issuecomment-727574114
I think this pr settles down `simd` feature's dependencies when avx512 is used. When this PR is merged it would be nice to document which one got selected. Like:
`cargo +nightly build --features=avx512,simd` This selects `avx512` with this pr in I presume. That's enough to document from my point of view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9337: [Rust] fix build for conditional compilation of features 'simd + avx512'
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9337:
URL: https://github.com/apache/arrow/pull/9337#issuecomment-768343917
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9337?src=pr&el=h1) Report
> Merging [#9337](https://codecov.io/gh/apache/arrow/pull/9337?src=pr&el=desc) (68c60cc) into [master](https://codecov.io/gh/apache/arrow/commit/ab5fc979c69ccc5dde07e1bc1467b02951b4b7e9?el=desc) (ab5fc97) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/9337?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9337 +/- ##
=======================================
Coverage 81.89% 81.89%
=======================================
Files 215 215
Lines 52988 52988
=======================================
Hits 43392 43392
Misses 9596 9596
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9337?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/buffer.rs](https://codecov.io/gh/apache/arrow/pull/9337/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyLnJz) | `96.21% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9337?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9337?src=pr&el=footer). Last update [ab5fc97...68c60cc](https://codecov.io/gh/apache/arrow/pull/9337?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9337: ARROW-11387: [Rust] fix build for conditional compilation of features 'simd + avx512'
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9337:
URL: https://github.com/apache/arrow/pull/9337#issuecomment-770049125
> Will this be published as a patch version to 3.0.0?
@ChristianBeilschmidt -- I do not know what the plans are for a 3.0.0 patch. @andygrove do you know of how/if we do such a thing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9337: ARROW-11387: [Rust] fix build for conditional compilation of features 'simd + avx512'
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9337:
URL: https://github.com/apache/arrow/pull/9337#issuecomment-770165556
I assigned both `4.0.0` and `3.0.1` to it, then. I agree that is a fix for a patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ChristianBeilschmidt commented on pull request #9337: ARROW-11387: [Rust] fix build for conditional compilation of features 'simd + avx512'
Posted by GitBox <gi...@apache.org>.
ChristianBeilschmidt commented on pull request #9337:
URL: https://github.com/apache/arrow/pull/9337#issuecomment-769832290
Will this be published as a patch version to 3.0.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org