You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Anonymitaet (via GitHub)" <gi...@apache.org> on 2023/02/17 05:26:30 UTC
[GitHub] [pulsar-site] Anonymitaet opened a new pull request, #422: [improve][doc] add instructions of env variables to CLI docs
Anonymitaet opened a new pull request, #422:
URL: https://github.com/apache/pulsar-site/pull/422
This PR:
- Fixes https://github.com/apache/pulsar/issues/19492
- Adds explanations to the homepages of several CLI tools
All previews look good:
<img width="1422" alt="image" src="https://user-images.githubusercontent.com/50226895/219556615-728e0403-2e04-4ada-93d6-610ff3b08583.png">
<img width="1199" alt="image" src="https://user-images.githubusercontent.com/50226895/219556683-2f1d4a9d-7ed1-47a6-8782-4fee06beda6c.png">
<img width="1221" alt="image" src="https://user-images.githubusercontent.com/50226895/219556754-da61019f-c433-4725-b749-488ab2909643.png">
<img width="1320" alt="image" src="https://user-images.githubusercontent.com/50226895/219556789-873d96c1-51d5-4910-b8a7-4ba87e07c44b.png">
cc @momo-jun @DaveDuggins @D-2-Ed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #422: [improve][doc] add instructions of env variables to CLI docs
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #422:
URL: https://github.com/apache/pulsar-site/pull/422#issuecomment-1434121464
@visortelle could you please help review? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #422: [improve][doc] add instructions of env variables to CLI docs
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #422:
URL: https://github.com/apache/pulsar-site/pull/422#issuecomment-1436188376
@baodi could you please help review? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet merged pull request #422: [improve][doc] add instructions of env variables to CLI docs
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet merged PR #422:
URL: https://github.com/apache/pulsar-site/pull/422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] github-actions[bot] commented on pull request #422: [improve][doc] add instructions of env variables to CLI docs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #422:
URL: https://github.com/apache/pulsar-site/pull/422#issuecomment-1434121478
@Anonymitaet Please add the following content to your PR description and select a checkbox:
```
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] visortelle commented on pull request #422: [improve][doc] add instructions of env variables to CLI docs
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on PR #422:
URL: https://github.com/apache/pulsar-site/pull/422#issuecomment-1438313051
@Anonymitaet completely missed the mention in the notification.
LGTM. Thank you for resolving the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org