[GitHub] [spark] zero323 commented on a change in pull request #34728: [SPARK-37474][R][DOCS] Migrate SparkR docs to pkgdown

[GitBox <gi...@apache.org>]

zero323 commented on a change in pull request #34728:
URL: https://github.com/apache/spark/pull/34728#discussion_r764032651



##########
File path: .github/workflows/build_and_test.yml
##########
@@ -489,6 +490,8 @@ jobs:
         apt-get update -y
         apt-get install -y ruby ruby-dev
         Rscript -e "install.packages(c('devtools', 'testthat', 'knitr', 'rmarkdown', 'roxygen2'), repos='https://cloud.r-project.org/')"
+        Rscript -e "devtools::install_git('https://github.com/r-lib/pkgdown.git')"
+        Rscript -e "devtools::install_git('https://github.com/amirmasoudabdol/preferably.git')"

Review comment:
       > quick question, do we need this for documentation build?
   
   Yes, documentation build invokes pkgdown. 
   
   > And can we pin the versions of both libraries instead of using the master branch?
   
   Of course. We should be even able to pin CRAN version of `pkgdown` (seems like [2.0.x](https://cloud.r-project.org/web/packages/pkgdown/index.html) and [compatible preferably](https://cloud.r-project.org/web/packages/preferably/))) are already published and visible). 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org