You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/15 02:24:42 UTC

[GitHub] [pulsar] HQebupt commented on a diff in pull request #15173: [cleanup][client] Cleanup the creation ssl context

HQebupt commented on code in PR #15173:
URL: https://github.com/apache/pulsar/pull/15173#discussion_r851010002


##########
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java:
##########
@@ -114,58 +107,14 @@ public boolean keepAlive(InetSocketAddress remoteAddress, Request ahcRequest,
         });
 
         serviceNameResolver = new PulsarServiceNameResolver();
-        if (conf != null && StringUtils.isNotBlank(conf.getServiceUrl())) {
+        if (StringUtils.isNotBlank(conf.getServiceUrl())) {

Review Comment:
   It seems that the` ClientConfigurationData conf` may be null in `PulsarAdmin`. Shall you keep the judgement to avoid NPE ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org