You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by edespino <gi...@git.apache.org> on 2016/09/20 07:47:43 UTC
[GitHub] incubator-hawq pull request #918: HAWQ-1062. Remove ASF incompatible Perl JS...
GitHub user edespino opened a pull request:
https://github.com/apache/incubator-hawq/pull/918
HAWQ-1062. Remove ASF incompatible Perl JSON module
* Remove JSON Perl Module (Artistic license) module (files and
directory) from source tree. The user wanting to run these Perl JSON
module dependent scripts (tidycat.pl, calico.pl, caqluniqdef.pl) are
instructed to download it from www.cpan.org if it is not found in dev
environment. Here is error message received if JSON Perl Module is
not found:
Fatal Error: The required package JSON is not installed -- please
download it from www.cpan.org
JSON Perl Module versions 2.27 through 2.90 are known to work.
* Update LICENSE file and remove licenses/LICENSE-json.txtfile.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/edespino/incubator-hawq 2.0.0.0-incubating-HAWQ-1062
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/918.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #918
----
commit b7c8717bda7af633573dc464bedac16eebefab1e
Author: Ed Espino <es...@apache.org>
Date: 2016-09-20T07:33:45Z
HAWQ-1062. Remove ASF incompatible Perl JSON module
* Remove JSON Perl Module (Artistic license) module (files and
directory) from source tree. The user wanting to run these Perl JSON
module dependent scripts (tidycat.pl, calico.pl, caqluniqdef.pl) are
instructed to download it from www.cpan.org if it is not found in dev
environment. Here is error message received if JSON Perl Module is
not found:
Fatal Error: The required package JSON is not installed -- please
download it from www.cpan.org
JSON Perl Module versions 2.27 through 2.90 are known to work.
* Update LICENSE file and remove licenses/LICENSE-json.txtfile.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-hawq/pull/918
@xunzhang - This is building the 2.0.0.0-incubating branch and this is known to not pass. The changes do not impact the build process.
@paul-guo- - I have added a section *Running catalog tidycat perl modules* to the build page https://cwiki.apache.org/confluence/display/HAWQ/Build+and+Install
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/918
Good to have this fix. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/918
Hi @edespino , I checked out the Travis Failure from https://s3.amazonaws.com/archive.travis-ci.org/jobs/161283621/log.txt. I think you should also modify lines around [here](https://github.com/apache/incubator-hawq/blob/master/src/backend/catalog/caql/Makefile#L175) together with this pull request~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/918
LGTM! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/918
I think we could add more details on wiki to save dev's time although dev do not call these perl script often. ed, you have had the successful experience so you can share on that page.
I just tried to install JSON perl module but failed, following the steps on http://www.cpan.org/modules/INSTALL.html
cpan App::cpanminus
cpanm Module::JSON
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-hawq/pull/918
You are correct Hong. I will also be updating it to fix the travis based
builds.
-=e
On Tue, Sep 20, 2016 at 4:48 AM, Hong Wu <no...@github.com> wrote:
> Hi @edespino <https://github.com/edespino> , I checked out the Travis
> Failure from https://s3.amazonaws.com/archive.travis-ci.org/jobs/
> 161283621/log.txt. I think you should also modify lines around here
> <https://github.com/apache/incubator-hawq/blob/master/src/backend/catalog/caql/Makefile#L175>
> together with this pull request~
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-hawq/pull/918#issuecomment-248278820>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABN-GjeE6C5EIREP7Bf3FR8tI4EXRt2Dks5qr8gqgaJpZM4KBUed>
> .
>
--
*Ed Espino*
*Director, Pivotal Technical Staff*
*Cell: *925.389.4640
*WeChat ID:* EdEspino
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/918
@edespino Cool, I missed the help info, that is enough. Seems Travis-CI failed, does this change affect building process?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #918: HAWQ-1062. Remove ASF incompatible Perl JSON modu...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-hawq/pull/918
@xunzhang - I feel the error message received when using the tools is sufficient enough. It informs the user the require JSON package is not installed and where to get it from (www.cpan.org). That should be sufficient for a developer to install the module for use with the Perl utilities. It is what I used when manually updating my system with the JSON module on my system in order to run the tidycat.pl utility. Is that sufficient?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #918: HAWQ-1062. Remove ASF incompatible Perl JS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/918
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---