You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/11 19:50:18 UTC

[GitHub] [tvm] driazati opened a new issue, #12388: [ci] Assert that Jenkinsfile changes also change the timestamp

driazati opened a new issue, #12388:
URL: https://github.com/apache/tvm/issues/12388

   Concurrent Jenkinsfile changes that happen in a sequence like:
   
   1. PR 1 makes changes
   2. PR 2 makes changes
   3. PR 1 merges
   4. PR 2 merges
   
   Can create a situation where both PRs pass CI but break `main` when merged with failures like https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/4024/pipeline.
   
   There is a timestamp in the `Jenkinsfile` that makes it so these PRs will have a merge conflict (in the example above PR 2 must be rebased and run through CI again before it can merge), we should check that any changes to the Jenkinsfile also change this timestamp (so if say PR 2 did not change the timestamp it wouldn't pass PR CI)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] driazati closed issue #12388: [ci] Assert that Jenkinsfile changes also change the timestamp

Posted by GitBox <gi...@apache.org>.
driazati closed issue #12388: [ci] Assert that Jenkinsfile changes also change the timestamp
URL: https://github.com/apache/tvm/issues/12388


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] driazati commented on issue #12388: [ci] Assert that Jenkinsfile changes also change the timestamp

Posted by GitBox <gi...@apache.org>.
driazati commented on issue #12388:
URL: https://github.com/apache/tvm/issues/12388#issuecomment-1317688301

   This isn't necessary in all cases anymore


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org