[kudu] branch master updated: [KUDU-3218] Ignore transaction clone symbols coming from std

[gr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new bd09924  [KUDU-3218] Ignore transaction clone symbols coming from std
bd09924 is described below

commit bd09924aa43bdb9701508d673fa088eb4f98217c
Author: Grant Henke <gr...@apache.org>
AuthorDate: Wed Dec 2 11:53:10 2020 -0600

    [KUDU-3218] Ignore transaction clone symbols coming from std
    
    To unbreak Centos 7 test runs this patch ignores the transaction clone
    symbols coming from `std::` in the client_symbol-test.
    
    A TODO remains to investigate further.
    
    Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
    Reviewed-on: http://gerrit.cloudera.org:8080/16810
    Tested-by: Kudu Jenkins
    Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
 src/kudu/client/client_symbol-test.sh | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/kudu/client/client_symbol-test.sh b/src/kudu/client/client_symbol-test.sh
index 2b5d0bc..cdb9f25 100755
--- a/src/kudu/client/client_symbol-test.sh
+++ b/src/kudu/client/client_symbol-test.sh
@@ -68,12 +68,20 @@ while read ADDR TYPE SYMBOL; do
     continue;
   fi
 
-  # KUDU-455: skip bizarro global symbol that remains when compiling with old gcc.
+  # KUDU-455: Skip bizarro global symbol that remains when compiling with old gcc.
   if [ "$SYMBOL" = "__gnu_cxx::hash<StringPiece>::operator()(StringPiece) const" ]; then
     echo "Skipping KUDU-455 symbol '$SYMBOL'"
     continue
   fi
 
+  # KUDU-3218: Skip transaction clone symbols coming from std.
+  # TODO(KUDU-3218): Validate these are safe to ignore long term.
+  if [[ "$SYMBOL" =~ ^"transaction clone for std::" ||
+        "$SYMBOL" =~ ^"operator delete" ]]; then
+    echo "Skipping transaction clone symbol (KUDU-3218) '$SYMBOL'"
+    continue;
+  fi
+
   # Any left over symbol is bad.
   echo "Found bad symbol '$SYMBOL'"
   NUM_BAD_SYMS=$((NUM_BAD_SYMS + 1))