You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by lavjain <gi...@git.apache.org> on 2018/01/17 21:27:40 UTC
[GitHub] incubator-hawq pull request #1330: Change PXF port number to 5888
GitHub user lavjain opened a pull request:
https://github.com/apache/incubator-hawq/pull/1330
Change PXF port number to 5888
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lavjain/incubator-hawq pxf_port_change
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1330.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1330
----
commit d256eaf8a31f55a46840ab3d46ef98e0be941df4
Author: lavjain <lj...@...>
Date: 2017-11-28T22:21:40Z
Change PXF port number to 5888
----
---
[GitHub] incubator-hawq pull request #1330: Change PXF port number to 5888
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1330#discussion_r162187040
--- Diff: pxf/pxf-service/src/scripts/pxf-service ---
@@ -21,25 +21,25 @@
#
-if [ -z $PXF_HOME ]; then
+if [ -z ${PXF_HOME} ]; then
parent_script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )/.." && pwd )"
- env_script=$parent_script_dir/conf/pxf-env.sh
+ env_script=${parent_script_dir}/conf/pxf-env.sh
else
- env_script=$PXF_HOME/conf/pxf-env.sh
+ env_script=${PXF_HOME}/conf/pxf-env.sh
fi
# load pxf-env.sh script
-if [ ! -f $env_script ]; then
+if [ ! -f ${env_script} ]; then
echo WARNING: failed to find $env_script
else
- source $env_script
+ source ${env_script}
fi
pxf_user=${PXF_USER}
instance_port=${PXF_PORT:-51200}
--- End diff --
Just confirming, do we want the service script to default to 51200 if PXF_PORT is not set ?
---
[GitHub] incubator-hawq pull request #1330: HAWQ-1580. Change PXF port number to 5888...
Posted by lavjain <gi...@git.apache.org>.
Github user lavjain closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1330
---
[GitHub] incubator-hawq issue #1330: Change PXF port number to 5888
Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on the issue:
https://github.com/apache/incubator-hawq/pull/1330
Will we also update HAWQ with the new default value ?
---
[GitHub] incubator-hawq issue #1330: Change PXF port number to 5888
Posted by lavjain <gi...@git.apache.org>.
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1330
https://issues.apache.org/jira/projects/HAWQ/issues/HAWQ-1580
---
[GitHub] incubator-hawq issue #1330: Change PXF port number to 5888
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on the issue:
https://github.com/apache/incubator-hawq/pull/1330
There are some references to port 51200 in some of our rest resource classes and also in the pxf-jdbc markdown file. Please update them as well.
---
[GitHub] incubator-hawq pull request #1330: Change PXF port number to 5888
Posted by denalex <gi...@git.apache.org>.
Github user denalex commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1330#discussion_r162192199
--- Diff: pxf/pxf-service/src/scripts/pxf-service ---
@@ -185,91 +185,74 @@ function doInit()
#
function configureWebapp()
{
- if [ -z $PXF_HOME ]; then
+ if [ -z ${PXF_HOME} ]; then
# webapp doesn't require patch
return 0
fi
- pushd $instance_root/$instance_name/webapps || return 1
+ pushd ${instance_root}/${instance_name}/webapps > /dev/null || return 1
rm -rf pxf
mkdir pxf
cd pxf
unzip -q ../pxf.war
- popd
+ popd > /dev/null
- context_file=$instance_root/$instance_name/webapps/pxf/META-INF/context.xml
- cat $context_file | \
- sed -e "s:classpathFiles=\"[a-zA-Z0-9\/\;.-]*\":classpathFiles=\"$PXF_HOME\/conf\/pxf-private.classpath\":" \
- -e "s:secondaryClasspathFiles=\"[a-zA-Z0-9\/\;.-]*\":secondaryClasspathFiles=\"$PXF_HOME\/conf\/pxf-public.classpath\":" > context.xml.tmp
- mv context.xml.tmp $context_file
+ context_file=${instance_root}/${instance_name}/webapps/pxf/META-INF/context.xml
+ sed -i -e "s:classpathFiles=\"[a-zA-Z0-9\/\;.-]*\":classpathFiles=\"${PXF_HOME}\/conf\/pxf-private.classpath\":" \
+ -e "s:secondaryClasspathFiles=\"[a-zA-Z0-9\/\;.-]*\":secondaryClasspathFiles=\"${PXF_HOME}\/conf\/pxf-public.classpath\":" ${context_file}
--- End diff --
nice, thanks for cleaning this up
---