You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by shardul-cr7 <gi...@git.apache.org> on 2018/12/13 08:47:13 UTC
[GitHub] carbondata pull request #2986: [CARBONDATA-3166]Updated Document and added C...
GitHub user shardul-cr7 opened a pull request:
https://github.com/apache/carbondata/pull/2986
[CARBONDATA-3166]Updated Document and added Column Compressor used in Describe Forma…
…tted Command
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shardul-cr7/carbondata DocUpdate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2986.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2986
----
commit 71cf4f0294adaaf2520d55fbb8b048494853896a
Author: shardul-cr7 <sh...@...>
Date: 2018-12-13T08:42:18Z
[]Updated Document and added column compressor used in Describe Formatted Command
----
---
[GitHub] carbondata issue #2986: [CARBONDATA-3166]Updated Document and added Column C...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2986
LGTM
---
[GitHub] carbondata pull request #2986: [CARBONDATA-3166]Updated Document and added C...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2986
---
[GitHub] carbondata issue #2986: [CARBONDATA-3166]Updated Document and added Column C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2986
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1735/
---
[GitHub] carbondata issue #2986: [CARBONDATA-3166]Updated Document and added Column C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2986
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1951/
---
[GitHub] carbondata issue #2986: [CARBONDATA-3166]Updated Document and added Column C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2986
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1946/
---
[GitHub] carbondata issue #2986: [CARBONDATA-3166]Updated Document and added Column C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2986
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1734/
---
[GitHub] carbondata issue #2986: [CARBONDATA-3166]Updated Document and added Column C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2986
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1740/
---
[GitHub] carbondata issue #2986: [CARBONDATA-3166]Updated Document and added Column C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2986
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9994/
---
[GitHub] carbondata issue #2986: [CARBONDATA-3166]Updated Document and added Column C...
Posted by KanakaKumar <gi...@git.apache.org>.
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2986
LGTM
---
[GitHub] carbondata issue #2986: [CARBONDATA-3166]Updated Document and added Column C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2986
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9999/
---
[GitHub] carbondata issue #2986: [CARBONDATA-3166]Updated Document and added Column C...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2986
I am with @KanakaKumar 's comments. We'd better not to show the system default value in the desc command for columncompressor, since the values can vary each time we changed that value. Maybe we can search advise for the other guys
---
[GitHub] carbondata pull request #2986: [CARBONDATA-3166]Updated Document and added C...
Posted by shardul-cr7 <gi...@git.apache.org>.
Github user shardul-cr7 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2986#discussion_r241376148
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala ---
@@ -92,7 +92,9 @@ private[sql] case class CarbonDescribeFormattedCommand(
Strings.formatSize(
tblProps.getOrElse(CarbonCommonConstants.CARBON_LOAD_MIN_SIZE_INMB,
CarbonCommonConstants.CARBON_LOAD_MIN_SIZE_INMB_DEFAULT).toFloat), ""),
-
+ ("Carbon Column Compressor ", tblProps
--- End diff --
Changed to "Data File Compressor"
As this is in table properties we are displaying default value.It's same for other properties also,
---
[GitHub] carbondata pull request #2986: [CARBONDATA-3166]Updated Document and added C...
Posted by KanakaKumar <gi...@git.apache.org>.
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2986#discussion_r241338497
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala ---
@@ -92,7 +92,9 @@ private[sql] case class CarbonDescribeFormattedCommand(
Strings.formatSize(
tblProps.getOrElse(CarbonCommonConstants.CARBON_LOAD_MIN_SIZE_INMB,
CarbonCommonConstants.CARBON_LOAD_MIN_SIZE_INMB_DEFAULT).toFloat), ""),
-
+ ("Carbon Column Compressor ", tblProps
--- End diff --
Same compressor is used for column and row data files. So, please change it to "Data File Compressor"
---
[GitHub] carbondata pull request #2986: [CARBONDATA-3166]Updated Document and added C...
Posted by KanakaKumar <gi...@git.apache.org>.
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2986#discussion_r241363901
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala ---
@@ -92,7 +92,9 @@ private[sql] case class CarbonDescribeFormattedCommand(
Strings.formatSize(
tblProps.getOrElse(CarbonCommonConstants.CARBON_LOAD_MIN_SIZE_INMB,
CarbonCommonConstants.CARBON_LOAD_MIN_SIZE_INMB_DEFAULT).toFloat), ""),
-
+ ("Carbon Column Compressor ", tblProps
--- End diff --
By default we should display empty instead of system default.
---
[GitHub] carbondata issue #2986: [CARBONDATA-3166]Updated Document and added Column C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2986
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9995/
---
[GitHub] carbondata pull request #2986: [CARBONDATA-3166]Updated Document and added C...
Posted by KanakaKumar <gi...@git.apache.org>.
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2986#discussion_r241477189
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDescribeFormattedCommand.scala ---
@@ -92,7 +92,9 @@ private[sql] case class CarbonDescribeFormattedCommand(
Strings.formatSize(
tblProps.getOrElse(CarbonCommonConstants.CARBON_LOAD_MIN_SIZE_INMB,
CarbonCommonConstants.CARBON_LOAD_MIN_SIZE_INMB_DEFAULT).toFloat), ""),
-
+ ("Carbon Column Compressor ", tblProps
--- End diff --
OK
---