You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2024/03/29 01:16:07 UTC

[PR] Hide internals of some groupped workflows [airflow]

potiuk opened a new pull request, #38604:
URL: https://github.com/apache/airflow/pull/38604

   When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow.
   
   This is what we do for Additional CI image tests and Finalize tests
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Hide internals of some groupped workflows [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #38604:
URL: https://github.com/apache/airflow/pull/38604#issuecomment-2027327357

   Merging. the "No pydantic" tests in main will be handled separately (need to skip some more tests in NoPydantic case).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Hide internals of some groupped workflows [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #38604:
URL: https://github.com/apache/airflow/pull/38604#issuecomment-2026857224

   Reopened to check with upgrade-to-newer-dependencies.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Hide internals of some groupped workflows [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #38604:
URL: https://github.com/apache/airflow/pull/38604#discussion_r1545495168


##########
.github/workflows/special-tests.yml:
##########
@@ -134,7 +134,7 @@ jobs:
       contents: read
       packages: read
     secrets: inherit
-    if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies == 'true'
+    if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies != 'false'

Review Comment:
   Actually.. i was wrong :) .
   
   When I look in detail it looks like the inputs/outputs were the same "true/false" like everything else - only the --build-arg UPGRADE_TO_NEWER_DEPENDENCIES required the random value I mentioned above (due to docker layer caching). I made it clearer - I hope in https://github.com/apache/airflow/pull/38637 by renaming the build-arg to UPGRADE_TO_NEWER_DEPENDENCIES_HASH and correcting the descriptions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Hide internals of some groupped workflows [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #38604:
URL: https://github.com/apache/airflow/pull/38604#discussion_r1544534177


##########
.github/workflows/special-tests.yml:
##########
@@ -134,7 +134,7 @@ jobs:
       contents: read
       packages: read
     secrets: inherit
-    if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies == 'true'
+    if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies != 'false'

Review Comment:
   It's different - because upgrade-to-newer-dependencies is either `false` or ... random hash :D. It's needed to make sure that appropriate Container layer gets invalidated (via build arg). I **think** I will need to add better description and likely change name of the parameter to reflect this because I keep on forgetting it myself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Hide internals of some groupped workflows [airflow]

Posted by "aritra24 (via GitHub)" <gi...@apache.org>.
aritra24 commented on code in PR #38604:
URL: https://github.com/apache/airflow/pull/38604#discussion_r1544497045


##########
.github/workflows/special-tests.yml:
##########
@@ -134,7 +134,7 @@ jobs:
       contents: read
       packages: read
     secrets: inherit
-    if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies == 'true'
+    if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies != 'false'

Review Comment:
   Just for my understanding how is this different?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Hide internals of some groupped workflows [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #38604: Hide internals of some groupped workflows
URL: https://github.com/apache/airflow/pull/38604


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Hide internals of some groupped workflows [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #38604:
URL: https://github.com/apache/airflow/pull/38604#issuecomment-2026431281

   Avoids this: 
   
   <img width="336" alt="Screenshot 2024-03-29 at 02 18 58" src="https://github.com/apache/airflow/assets/595491/07e726a4-6964-4cb8-bbb8-2ced24a4a1b4">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Hide internals of some groupped workflows [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #38604:
URL: https://github.com/apache/airflow/pull/38604#issuecomment-2027243784

   Should be good to go - seems to pass all the variants


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Hide internals of some groupped workflows [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #38604:
URL: https://github.com/apache/airflow/pull/38604


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org