[GitHub] [hudi] danny0405 commented on a diff in pull request #7760: [HUDI-5626] Rename CDC logging mode options and fix flink's default

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #7760:
URL: https://github.com/apache/hudi/pull/7760#discussion_r1088724200


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -168,12 +169,11 @@ private FlinkOptions() {
   public static final ConfigOption<String> SUPPLEMENTAL_LOGGING_MODE = ConfigOptions
       .key("cdc.supplemental.logging.mode")
       .stringType()
-      .defaultValue("cdc_data_before_after") // default record all the change log images
+      .defaultValue(op_key_only.name())
       .withFallbackKeys(HoodieTableConfig.CDC_SUPPLEMENTAL_LOGGING_MODE.key())

Review Comment:
   Let's keep the default value of Flink as `data_before_after`, there are some issues maybe for the other 2 modes because Flink can trigger eager flush, the intermediate data file may cause changes loss, we can switch to other modes when I fix that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org