You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ke...@apache.org on 2003/07/03 02:16:49 UTC
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteAdapter.java
keith 2003/07/02 17:16:49
Modified: catalina/src/share/org/apache/coyote/tomcat5
CoyoteAdapter.java
Log:
Allow * as a valid url
Revision Changes Path
1.8 +8 -4 jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteAdapter.java
Index: CoyoteAdapter.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteAdapter.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- CoyoteAdapter.java 19 May 2003 22:44:20 -0000 1.7
+++ CoyoteAdapter.java 3 Jul 2003 00:16:49 -0000 1.8
@@ -480,6 +480,10 @@
int start = uriBC.getStart();
int end = uriBC.getEnd();
+ // URL * is acceptable
+ if ((end - start == 1) && b[start] == (byte) '*')
+ return true;
+
int pos = 0;
int index = 0;
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteAdapter.java
Posted by Bill Barker <wb...@wilshire.com>.
----- Original Message -----
From: "Remy Maucherat" <re...@apache.org>
To: "Tomcat Developers List" <to...@jakarta.apache.org>
Sent: Wednesday, July 02, 2003 11:49 PM
Subject: Re: cvs commit:
jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5
CoyoteAdapter.java
> keith@apache.org wrote:
> > keith 2003/07/02 17:16:49
> >
> > Modified: catalina/src/share/org/apache/coyote/tomcat5
> > CoyoteAdapter.java
> > Log:
> > Allow * as a valid url
>
> Errr, ok, well, that's a possibly risky patch. I think that does get
> mapped to the root context and its default servlet (and the servlet path
> should be "*").
> I verified a "/*" security constraint mapping matched this URL.
>
I've checked this briefly. It looks Ok to me. The original problem was
with:
$ telnet localhost 8080
OPTIONS * /HTTP1.1
Host: localhost:8080
Previously this would generate a 400 error. Now it generates the correct
values for the OPTIONS with a (correct) 200 response.
> Remy
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
>
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5
CoyoteAdapter.java
Posted by Remy Maucherat <re...@apache.org>.
Keith Wannamaker wrote:
> Hi Remy, * does map to the default context. Can you think of any special
> downstream handling that we should do for '*'?
Well, nothing as far as I am concerned. I couldn't find any side effect
or security problem introduced by your patch, so I'm +0 for it.
Remy
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
RE: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteAdapter.java
Posted by Keith Wannamaker <Ke...@Wannamaker.org>.
Hi Remy, * does map to the default context. Can you think of any special
downstream handling that we should do for '*'?
Keith
| -----Original Message-----
| From: Remy Maucherat [mailto:remm@apache.org]
| Sent: Thursday, July 03, 2003 2:50 AM
| To: Tomcat Developers List
| Subject: Re: cvs commit:
| jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5
| CoyoteAdapter.java
|
|
| keith@apache.org wrote:
| > keith 2003/07/02 17:16:49
| >
| > Modified: catalina/src/share/org/apache/coyote/tomcat5
| > CoyoteAdapter.java
| > Log:
| > Allow * as a valid url
|
| Errr, ok, well, that's a possibly risky patch. I think that does get
| mapped to the root context and its default servlet (and the servlet path
| should be "*").
| I verified a "/*" security constraint mapping matched this URL.
|
| Remy
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5
CoyoteAdapter.java
Posted by Remy Maucherat <re...@apache.org>.
keith@apache.org wrote:
> keith 2003/07/02 17:16:49
>
> Modified: catalina/src/share/org/apache/coyote/tomcat5
> CoyoteAdapter.java
> Log:
> Allow * as a valid url
Errr, ok, well, that's a possibly risky patch. I think that does get
mapped to the root context and its default servlet (and the servlet path
should be "*").
I verified a "/*" security constraint mapping matched this URL.
Remy
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org