[jira] [Commented] (ACE-343) Make sure all bundles and exported packages are versioned as 1.0

["Bram de Kruijff (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACE-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658797#comment-13658797 ] 

Bram de Kruijff commented on ACE-343:
-------------------------------------

Hi Christian, thanks for the patch. It is in the right directoin, but has some issues (and does not apply cleanly for me)

Export versions for "ace packages should be specified in the "packageinfo" file in the package so bnd(tools) can manage it. Eg. in the snippet below you add the version directive to the deployment package export. However, if you look in the source package there is allready a packageinfo specifying it as 1.0. So in this case your addition is superfluous.

{code}
Index: api.bnd
===================================================================
--- api.bnd	(revision 1470294)
+++ api.bnd	(working copy)
@@ -1,2 +1,2 @@
-Export-Package: org.apache.ace.deployment
+Export-Package: org.apache.ace.deployment;version=1.0.0
{code}


I think that the fact that the patch does not apply clealy for me has to do with the fact that it is an eclipse workspace patch and it includes svn:propset and I do not have subclipse installed(?) I can probably figure it out, but in future I'd be happier with regular patch files :)

                
> Make sure all bundles and exported packages are versioned as 1.0
> ----------------------------------------------------------------
>
>                 Key: ACE-343
>                 URL: https://issues.apache.org/jira/browse/ACE-343
>             Project: ACE
>          Issue Type: Task
>            Reporter: Christian Vogel
>            Priority: Minor
>         Attachments: issue-343.patch
>
>
> as the title say's...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira