You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/06 03:59:34 UTC

[GitHub] [shardingsphere] soulasuna opened a new pull request #11676: Shadow core reconstruction

soulasuna opened a new pull request #11676:
URL: https://github.com/apache/shardingsphere/pull/11676


   ## Shadow core reconstruction
   For  #11661.
   
   Refactor for shardingsphere-shadow-core.
   -  Add shadow algorithm basic implement.
   -  Refactor the shadow rule builder.
   -  Refactor the yaml shadow rule configuration.
   -  Refactor the yaml shadow rule configuration swapper.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter commented on pull request #11676: Shadow core reconstruction

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11676:
URL: https://github.com/apache/shardingsphere/pull/11676#issuecomment-894018900


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11676?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11676](https://codecov.io/gh/apache/shardingsphere/pull/11676?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24d3473) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a2fc27a46887513b7e4980a1f4d35675b4c22780?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2fc27a) will **decrease** coverage by `0.07%`.
   > The diff coverage is `38.21%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11676/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11676      +/-   ##
   ============================================
   - Coverage     63.85%   63.77%   -0.08%     
     Complexity     1121     1121              
   ============================================
     Files          2254     2264      +10     
     Lines         34447    34594     +147     
     Branches       6018     6026       +8     
   ============================================
   + Hits          21996    22063      +67     
   - Misses        10678    10756      +78     
   - Partials       1773     1775       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11676?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../datasource/YamlShadowDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/11676/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cveWFtbC9jb25maWcvZGF0YXNvdXJjZS9ZYW1sU2hhZG93RGF0YVNvdXJjZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...aml/config/table/YamlShadowTableConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/11676/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cveWFtbC9jb25maWcvdGFibGUvWWFtbFNoYWRvd1RhYmxlQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...RuleAlgorithmProviderConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/11676/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cveWFtbC9zd2FwcGVyL1NoYWRvd1J1bGVBbGdvcml0aG1Qcm92aWRlckNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `12.50% <12.50%> (ø)` | |
   | [...urce/ShadowDataSourceConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/11676/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cveWFtbC9zd2FwcGVyL2RhdGFzb3VyY2UvU2hhZG93RGF0YVNvdXJjZUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `16.66% <16.66%> (ø)` | |
   | [...per/table/ShadowTableConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/11676/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cveWFtbC9zd2FwcGVyL3RhYmxlL1NoYWRvd1RhYmxlQ29uZmlndXJhdGlvbllhbWxTd2FwcGVyLmphdmE=) | `20.00% <20.00%> (ø)` | |
   | [.../apache/shardingsphere/shadow/rule/ShadowRule.java](https://codecov.io/gh/apache/shardingsphere/pull/11676/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcnVsZS9TaGFkb3dSdWxlLmphdmE=) | `34.37% <28.57%> (-20.18%)` | :arrow_down: |
   | [...hecker/AbstractShadowRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/11676/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcnVsZS9jaGVja2VyL0Fic3RyYWN0U2hhZG93UnVsZUNvbmZpZ3VyYXRpb25DaGVja2VyLmphdmE=) | `42.85% <42.85%> (ø)` | |
   | [...ml/swapper/ShadowRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/11676/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cveWFtbC9zd2FwcGVyL1NoYWRvd1J1bGVDb25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `60.00% <58.62%> (-10.00%)` | :arrow_down: |
   | [...gorithmProvidedShadowRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/11676/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcnVsZS9jaGVja2VyL0FsZ29yaXRobVByb3ZpZGVkU2hhZG93UnVsZUNvbmZpZ3VyYXRpb25DaGVja2VyLmphdmE=) | `60.00% <60.00%> (ø)` | |
   | [...w/algorithm/ColumnRegularMatchShadowAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/11676/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvYWxnb3JpdGhtL0NvbHVtblJlZ3VsYXJNYXRjaFNoYWRvd0FsZ29yaXRobS5qYXZh) | `66.66% <66.66%> (ø)` | |
   | ... and [27 more](https://codecov.io/gh/apache/shardingsphere/pull/11676/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11676?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11676?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a2fc27a...24d3473](https://codecov.io/gh/apache/shardingsphere/pull/11676?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero merged pull request #11676: Shadow core reconstruction

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #11676:
URL: https://github.com/apache/shardingsphere/pull/11676


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org