[jira] [Commented] (THRIFT-847) Test Framework harmonization across all languages

["Roger Meier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026941#comment-14026941 ] 

Roger Meier commented on THRIFT-847:
------------------------------------

Thanks Chamila!

To your questions:
1. yes, please add this should be supported
2. I have removed them
3. I guess testStringMap was introduced later and was probably not implemented on every language

great work!
-roger

> Test Framework harmonization across all languages
> -------------------------------------------------
>
>                 Key: THRIFT-847
>                 URL: https://issues.apache.org/jira/browse/THRIFT-847
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C# - Library, C++ - Library, Cocoa - Library, Erlang - Library, Haskell - Library, Java - Library, JavaScript - Library, OCaml - Library, Perl - Library, PHP - Library, Python - Library, Ruby - Library, Test Suite
>    Affects Versions: 0.1, 0.2, 0.3
>            Reporter: Roger Meier
>            Assignee: Roger Meier
>              Labels: gsoc2014, mentor
>         Attachments: 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, THRIFT-847_add__make_cross__build_target.patch, build.xml, test.sh, v1-WORK_IN_PROGRESS-unified_tests.tar.gz
>
>
> Today each Language supported by Thrift, have its own unit test, all are using the same Thrift IDL's located at the test directory. But the behavior of these tests seems to be different from language to language... this makes it difficult to do tests and bug fixing across different Languages. e.g.
> * C++ Test and JavaScript Test Server written in Java have different responses for the same services
> * C# and Java Test Server have different responses for testException as C++
> I propose the following steps:
> * identify the language with the reference implementation (well defined return values for all test cases) 
> * update the ThriftTest.thrift with details about the required return values that have to be implemented
> * update test implementations and move language tests into their appropriate library directory (THRIFT-35)
> * a public test server that supports multiple protocols and transports could be another enhancement for testing purposes
> I'm ready to help preparing patches, just tell me what you need!



--
This message was sent by Atlassian JIRA
(v6.2#6252)