[GitHub] [airflow] ecerulm commented on pull request #16678: WIP: Solve timezone serialization by adding a schedule_timezone parameter to DAG

[GitBox <gi...@apache.org>]

ecerulm commented on pull request #16678:
URL: https://github.com/apache/airflow/pull/16678#issuecomment-869208645


   >It’s not clear to me why a new argument is needed to solve this.
   >....
   > and the problem’s solution is the same regardless of it.
   
   well that's exactly the issue, The **partial** solution is the same, but the I believe that the true only solution is to make the user specify the timezone as as a string or int  instead of trying to get it as `datetime.tzinfo` (of pendulum's subclasses).  But, yes, you are right, there is no need to introduce that new argument just to have an equivalent of the  #16631 implementation
   
   I just tried to create an AIP at https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals  and I don't have permissions to do it.
   
   Anyway, I'll just wait to see @ashb  comments as well, because first somebody needs to decide if we want to handle the problem in the DAG.__init__() , so that serialize/deserialize is simpler like in this PR, or handle it at deserialization time like in #16631. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org