[jira] [Commented] (TAJO-182) Correct NULL value handling of primitive operators

["Jinho Kim (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855387#comment-13855387 ] 

Jinho Kim commented on TAJO-182:
--------------------------------

+1 
This patch looks great to me.

> Correct NULL value handling of primitive operators
> --------------------------------------------------
>
>                 Key: TAJO-182
>                 URL: https://issues.apache.org/jira/browse/TAJO-182
>             Project: Tajo
>          Issue Type: Bug
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>            Priority: Critical
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-182.patch, TAJO-182_2.patch, TAJO-182_3.patch
>
>
> -If some domain value is compared to Null value, the current implementation will cause InvalidOperationException. Such cases should result in 'false'.-
> -If some domain value is compared to Null value, the current implementation will cause either InvalidOperationException or FALSE. Such cases should result in NULL.-
> Many primitive operators including arithmetic and comparison do not consider three valued logic. This patch corrects this problem. The original issue title was 'Comparison of primitive values including null value should return NULL.' This issue was expanded for null value handling of all primitive operators.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)