You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org> on 2006/03/20 16:16:00 UTC
[jira] Commented: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=comments#action_12371094 ]
Jacek Laskowski commented on GERONIMO-1754:
-------------------------------------------
Committed revision 387218. Thanks Rick!
Some comments:
* The ASL header should contain 'Copyright 2006' rather than 'Copyright 2004' (fixed)
* Why do you use literal strings rathen than constants, e.g. mail.nntp.quitwait - it's less error-prone
Before I close the issue, please submit another patch with these constants in (or provide some explanation why it only adds unnecessary burden ;))
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Attachments: GERONIMO-1754.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira