You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Shai Erera <se...@gmail.com> on 2009/08/13 15:15:03 UTC
Java 5 creeped again to Benchmark?
I up SVN and noticed some compilation errors in my eclipse in
SearchTravRetVectorHighlightTask. I added FastVectorHighlighter to my build
path, but it failed again because the latter is Java 1.5 compliant, and I
set the compiler level to 1.4 (to comply w/ core and benchmark level).
Maybe this task should be put aside until we upgrade benchmark to 1.5?
Shai
Re: Java 5 creeped again to Benchmark?
Posted by Michael McCandless <lu...@mikemccandless.com>.
Heh :)
Though... that was different, because that code hadn't been created
yet (I think) and so you were asking whether you could use 1.5. The
added work & cost of sticking with 1.4 was basically zero.
Whereas in this case we have new and useful functionality (the new
"fast vector highlighter") that we'll have to pull, and, I don't think
anyone will make the effort to fix the new highlighter to be 1.5.
Ie, for this case (since we'll lose something) it's compelling to now
accept 1.5 for benchmark.
Mike
On Thu, Aug 13, 2009 at 12:03 PM, Michael
McCandless<lu...@mikemccandless.com> wrote:
> I could go for that as well :)
>
> Mike
>
> On Thu, Aug 13, 2009 at 12:02 PM, Mark Miller<ma...@gmail.com> wrote:
>> I'd almost just say Benchmark is 1.5 now. We try to keep contrib things that
>> are 1.4 at 1.4, but why bend over backwards here to pull that task out?
>> Technically there is no back compat promise here.
>>
>> The number of people relying on 1.4 for Benchmark has got to be ...
>>
>>
>> Michael McCandless wrote:
>>>
>>> Sigh. I guess we have to pull that task for 2.9.
>>>
>>> I'll reopen the original issue (LUCENE-1773), note this, and mark it
>>> as fix for 3.0.
>>>
>>> Mike
>>>
>>> On Thu, Aug 13, 2009 at 11:24 AM, Shai Erera<se...@gmail.com> wrote:
>>>
>>>>
>>>> Me too ... and you were suggesting to hold off w/ 3.0 and having 2.5 and
>>>> then 2.9 ... :).
>>>>
>>>> What do you think I should do w/ that task in the meantime?
>>>>
>>>> Shai
>>>>
>>>> On Thu, Aug 13, 2009 at 6:21 PM, Grant Ingersoll <gs...@apache.org>
>>>> wrote:
>>>>
>>>>>
>>>>> I _so_ can't wait to have this one off of our back for a while. Of
>>>>> course, then we'll have 1.6 creep... ;-)
>>>>>
>>>>> On Aug 13, 2009, at 9:15 AM, Shai Erera wrote:
>>>>>
>>>>>
>>>>>>
>>>>>> I up SVN and noticed some compilation errors in my eclipse in
>>>>>> SearchTravRetVectorHighlightTask. I added FastVectorHighlighter to my
>>>>>> build
>>>>>> path, but it failed again because the latter is Java 1.5 compliant, and
>>>>>> I
>>>>>> set the compiler level to 1.4 (to comply w/ core and benchmark level).
>>>>>>
>>>>>> Maybe this task should be put aside until we upgrade benchmark to 1.5?
>>>>>>
>>>>>> Shai
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>>>
>>>>>
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>
>>>
>>
>>
>> --
>> - Mark
>>
>> http://www.lucidimagination.com
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Java 5 creeped again to Benchmark?
Posted by DM Smith <dm...@gmail.com>.
On 08/13/2009 01:56 PM, Mark Miller wrote:
> Shai Erera wrote:
>> So far Mike has resolved the issue again, so it sounds like we go w/
>> it ?
>>
> Lazy consensus - so its lookin good so far - but someone could still
> derail us I suppose.
>
I've been a stick-in-the-mud wrt migrating to Java 5 in the past.
That said, I think that tests and benchmarks are QA tools and as such
shouldn't be constrained to a particular version of Java. Even though
code may be 1.4.2 most are using Java 5 or 6 for runtime. I think it is
reasonable to benchmark using what end users use.
-- DM
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Java 5 creeped again to Benchmark?
Posted by Mark Miller <ma...@gmail.com>.
Shai Erera wrote:
> So far Mike has resolved the issue again, so it sounds like we go w/ it ?
>
Lazy consensus - so its lookin good so far - but someone could still
derail us I suppose.
--
- Mark
http://www.lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Java 5 creeped again to Benchmark?
Posted by Shai Erera <se...@gmail.com>.
So far Mike has resolved the issue again, so it sounds like we go w/ it ?
Going forward, what about contribs that are on Java 1.6?
Personally I don't think it's wrong that benchmark will be on Java 1.5 or
even 1.6. Even that Lucene is 1.4, I believe many run it w/ 1.5 or 1.6, so
testing Lucene w/ those JVMs is not wrong. And I don't just mean running w/
a 1.6 JVM, but actually using 1.6 stuff. This also emulates real
applications that use 1.6 stuff, while Lucene is 1.4.
Shai
On Thu, Aug 13, 2009 at 7:24 PM, Mark Miller <ma...@gmail.com> wrote:
>
> Shai Erera wrote:
>
>> On my next Benchmark issue will I be free to use 1.5 stuff? (kidding)
>>
>> If we go with this than yes ;)
>
> And if you had argued before that you wanted to test a 1.5 module with
> Benchmark, I would have voted right behind you as well. Generics wasn't
> enough to sway me :)
>
>
> --
> - Mark
>
> http://www.lucidimagination.com
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
Re: Java 5 creeped again to Benchmark?
Posted by Mark Miller <ma...@gmail.com>.
Shai Erera wrote:
> On my next Benchmark issue will I be free to use 1.5 stuff? (kidding)
>
If we go with this than yes ;)
And if you had argued before that you wanted to test a 1.5 module with
Benchmark, I would have voted right behind you as well. Generics wasn't
enough to sway me :)
--
- Mark
http://www.lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Java 5 creeped again to Benchmark?
Posted by Shai Erera <se...@gmail.com>.
Like I said - you won't hear me complaining. On my next Benchmark issue will
I be free to use 1.5 stuff? (kidding)
Though... that was different, because that code hadn't been created yet
I actually did write the code, but didn't post the patch - so I guess it
doesn't count :).
I'm fine w/ it, I'll just change my compiler level to 1.5.
On Thu, Aug 13, 2009 at 7:14 PM, Mark Miller <ma...@gmail.com> wrote:
> Thats fair -
>
> My inclination for anything in Contrib off the top is to keep it at 1.4 if
> its already at 1.4 - especially concerning language constructs and what not.
>
> However, this task is already in, it's nice to have, and thats enough to
> sway me here.
>
> The point that really gets me is that Benchmark is in contrib, and works
> with other contrib modules - if other contrib modules can be 1.5, it makes
> sense that they should work with Benchmark in my opinion.
>
> If this was "some java 1.5 generics" or what not snuck in - I would say
> remove it and make it 1.4. But remove a task that adds value and lets you
> compare Highlighter approaches? I'd vote to keep it.
>
> - Mark
>
> Shai Erera wrote:
>
>> Umm ... not that I'll complain, but look here:
>> https://issues.apache.org/jira/browse/LUCENE-1595?focusedCommentId=12711586&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12711586<
>> https://issues.apache.org/jira/browse/LUCENE-1595?focusedCommentId=12711586&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12711586
>> >
>>
>> And read the comments from both of you below :).
>>
>> I soooo wanted to use generics in Benchmark in that patch :).
>>
>> Shai
>>
>> On Thu, Aug 13, 2009 at 7:03 PM, Michael McCandless <
>> lucene@mikemccandless.com <ma...@mikemccandless.com>> wrote:
>>
>> I could go for that as well :)
>>
>> Mike
>>
>> On Thu, Aug 13, 2009 at 12:02 PM, Mark
>> Miller<markrmiller@gmail.com <ma...@gmail.com>> wrote:
>> > I'd almost just say Benchmark is 1.5 now. We try to keep contrib
>> things that
>> > are 1.4 at 1.4, but why bend over backwards here to pull that
>> task out?
>> > Technically there is no back compat promise here.
>> >
>> > The number of people relying on 1.4 for Benchmark has got to be ...
>> >
>> >
>> > Michael McCandless wrote:
>> >>
>> >> Sigh. I guess we have to pull that task for 2.9.
>> >>
>> >> I'll reopen the original issue (LUCENE-1773), note this, and
>> mark it
>> >> as fix for 3.0.
>> >>
>> >> Mike
>> >>
>> >> On Thu, Aug 13, 2009 at 11:24 AM, Shai Erera<serera@gmail.com
>> <ma...@gmail.com>> wrote:
>> >>
>> >>>
>> >>> Me too ... and you were suggesting to hold off w/ 3.0 and
>> having 2.5 and
>> >>> then 2.9 ... :).
>> >>>
>> >>> What do you think I should do w/ that task in the meantime?
>> >>>
>> >>> Shai
>> >>>
>> >>> On Thu, Aug 13, 2009 at 6:21 PM, Grant Ingersoll
>> <gsingers@apache.org <ma...@apache.org>>
>> >>> wrote:
>> >>>
>> >>>>
>> >>>> I _so_ can't wait to have this one off of our back for a
>> while. Of
>> >>>> course, then we'll have 1.6 creep... ;-)
>> >>>>
>> >>>> On Aug 13, 2009, at 9:15 AM, Shai Erera wrote:
>> >>>>
>> >>>>
>> >>>>>
>> >>>>> I up SVN and noticed some compilation errors in my eclipse in
>> >>>>> SearchTravRetVectorHighlightTask. I added
>> FastVectorHighlighter to my
>> >>>>> build
>> >>>>> path, but it failed again because the latter is Java 1.5
>> compliant, and
>> >>>>> I
>> >>>>> set the compiler level to 1.4 (to comply w/ core and
>> benchmark level).
>> >>>>>
>> >>>>> Maybe this task should be put aside until we upgrade
>> benchmark to 1.5?
>> >>>>>
>> >>>>> Shai
>> >>>>>
>> >>>>
>> >>>>
>> ---------------------------------------------------------------------
>> >>>> To unsubscribe, e-mail:
>> java-dev-unsubscribe@lucene.apache.org
>> <ma...@lucene.apache.org>
>> >>>> For additional commands, e-mail:
>> java-dev-help@lucene.apache.org
>> <ma...@lucene.apache.org>
>> >>>>
>> >>>>
>> >>>
>> >>>
>> >>
>> >>
>> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> <ma...@lucene.apache.org>
>> >> For additional commands, e-mail:
>> java-dev-help@lucene.apache.org
>> <ma...@lucene.apache.org>
>> >>
>> >>
>> >
>> >
>> > --
>> > - Mark
>> >
>> > http://www.lucidimagination.com
>> >
>> >
>> >
>> >
>> >
>> ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> <ma...@lucene.apache.org>
>> > For additional commands, e-mail: java-dev-help@lucene.apache.org
>> <ma...@lucene.apache.org>
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> <ma...@lucene.apache.org>
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>> <ma...@lucene.apache.org>
>>
>>
>>
>
> --
> - Mark
>
> http://www.lucidimagination.com
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
Re: Java 5 creeped again to Benchmark?
Posted by Mark Miller <ma...@gmail.com>.
Thats fair -
My inclination for anything in Contrib off the top is to keep it at 1.4
if its already at 1.4 - especially concerning language constructs and
what not.
However, this task is already in, it's nice to have, and thats enough to
sway me here.
The point that really gets me is that Benchmark is in contrib, and works
with other contrib modules - if other contrib modules can be 1.5, it
makes sense that they should work with Benchmark in my opinion.
If this was "some java 1.5 generics" or what not snuck in - I would say
remove it and make it 1.4. But remove a task that adds value and lets
you compare Highlighter approaches? I'd vote to keep it.
- Mark
Shai Erera wrote:
> Umm ... not that I'll complain, but look here:
> https://issues.apache.org/jira/browse/LUCENE-1595?focusedCommentId=12711586&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12711586
> <https://issues.apache.org/jira/browse/LUCENE-1595?focusedCommentId=12711586&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12711586>
>
> And read the comments from both of you below :).
>
> I soooo wanted to use generics in Benchmark in that patch :).
>
> Shai
>
> On Thu, Aug 13, 2009 at 7:03 PM, Michael McCandless
> <lucene@mikemccandless.com <ma...@mikemccandless.com>> wrote:
>
> I could go for that as well :)
>
> Mike
>
> On Thu, Aug 13, 2009 at 12:02 PM, Mark
> Miller<markrmiller@gmail.com <ma...@gmail.com>> wrote:
> > I'd almost just say Benchmark is 1.5 now. We try to keep contrib
> things that
> > are 1.4 at 1.4, but why bend over backwards here to pull that
> task out?
> > Technically there is no back compat promise here.
> >
> > The number of people relying on 1.4 for Benchmark has got to be ...
> >
> >
> > Michael McCandless wrote:
> >>
> >> Sigh. I guess we have to pull that task for 2.9.
> >>
> >> I'll reopen the original issue (LUCENE-1773), note this, and
> mark it
> >> as fix for 3.0.
> >>
> >> Mike
> >>
> >> On Thu, Aug 13, 2009 at 11:24 AM, Shai Erera<serera@gmail.com
> <ma...@gmail.com>> wrote:
> >>
> >>>
> >>> Me too ... and you were suggesting to hold off w/ 3.0 and
> having 2.5 and
> >>> then 2.9 ... :).
> >>>
> >>> What do you think I should do w/ that task in the meantime?
> >>>
> >>> Shai
> >>>
> >>> On Thu, Aug 13, 2009 at 6:21 PM, Grant Ingersoll
> <gsingers@apache.org <ma...@apache.org>>
> >>> wrote:
> >>>
> >>>>
> >>>> I _so_ can't wait to have this one off of our back for a
> while. Of
> >>>> course, then we'll have 1.6 creep... ;-)
> >>>>
> >>>> On Aug 13, 2009, at 9:15 AM, Shai Erera wrote:
> >>>>
> >>>>
> >>>>>
> >>>>> I up SVN and noticed some compilation errors in my eclipse in
> >>>>> SearchTravRetVectorHighlightTask. I added
> FastVectorHighlighter to my
> >>>>> build
> >>>>> path, but it failed again because the latter is Java 1.5
> compliant, and
> >>>>> I
> >>>>> set the compiler level to 1.4 (to comply w/ core and
> benchmark level).
> >>>>>
> >>>>> Maybe this task should be put aside until we upgrade
> benchmark to 1.5?
> >>>>>
> >>>>> Shai
> >>>>>
> >>>>
> >>>>
> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail:
> java-dev-unsubscribe@lucene.apache.org
> <ma...@lucene.apache.org>
> >>>> For additional commands, e-mail:
> java-dev-help@lucene.apache.org
> <ma...@lucene.apache.org>
> >>>>
> >>>>
> >>>
> >>>
> >>
> >>
> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> <ma...@lucene.apache.org>
> >> For additional commands, e-mail:
> java-dev-help@lucene.apache.org
> <ma...@lucene.apache.org>
> >>
> >>
> >
> >
> > --
> > - Mark
> >
> > http://www.lucidimagination.com
> >
> >
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> <ma...@lucene.apache.org>
> > For additional commands, e-mail: java-dev-help@lucene.apache.org
> <ma...@lucene.apache.org>
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> <ma...@lucene.apache.org>
> For additional commands, e-mail: java-dev-help@lucene.apache.org
> <ma...@lucene.apache.org>
>
>
--
- Mark
http://www.lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Java 5 creeped again to Benchmark?
Posted by Shai Erera <se...@gmail.com>.
Umm ... not that I'll complain, but look here:
https://issues.apache.org/jira/browse/LUCENE-1595?focusedCommentId=12711586&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12711586
And read the comments from both of you below :).
I soooo wanted to use generics in Benchmark in that patch :).
Shai
On Thu, Aug 13, 2009 at 7:03 PM, Michael McCandless <
lucene@mikemccandless.com> wrote:
> I could go for that as well :)
>
> Mike
>
> On Thu, Aug 13, 2009 at 12:02 PM, Mark Miller<ma...@gmail.com>
> wrote:
> > I'd almost just say Benchmark is 1.5 now. We try to keep contrib things
> that
> > are 1.4 at 1.4, but why bend over backwards here to pull that task out?
> > Technically there is no back compat promise here.
> >
> > The number of people relying on 1.4 for Benchmark has got to be ...
> >
> >
> > Michael McCandless wrote:
> >>
> >> Sigh. I guess we have to pull that task for 2.9.
> >>
> >> I'll reopen the original issue (LUCENE-1773), note this, and mark it
> >> as fix for 3.0.
> >>
> >> Mike
> >>
> >> On Thu, Aug 13, 2009 at 11:24 AM, Shai Erera<se...@gmail.com> wrote:
> >>
> >>>
> >>> Me too ... and you were suggesting to hold off w/ 3.0 and having 2.5
> and
> >>> then 2.9 ... :).
> >>>
> >>> What do you think I should do w/ that task in the meantime?
> >>>
> >>> Shai
> >>>
> >>> On Thu, Aug 13, 2009 at 6:21 PM, Grant Ingersoll <gs...@apache.org>
> >>> wrote:
> >>>
> >>>>
> >>>> I _so_ can't wait to have this one off of our back for a while. Of
> >>>> course, then we'll have 1.6 creep... ;-)
> >>>>
> >>>> On Aug 13, 2009, at 9:15 AM, Shai Erera wrote:
> >>>>
> >>>>
> >>>>>
> >>>>> I up SVN and noticed some compilation errors in my eclipse in
> >>>>> SearchTravRetVectorHighlightTask. I added FastVectorHighlighter to my
> >>>>> build
> >>>>> path, but it failed again because the latter is Java 1.5 compliant,
> and
> >>>>> I
> >>>>> set the compiler level to 1.4 (to comply w/ core and benchmark
> level).
> >>>>>
> >>>>> Maybe this task should be put aside until we upgrade benchmark to
> 1.5?
> >>>>>
> >>>>> Shai
> >>>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> >>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
> >>>>
> >>>>
> >>>
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> >> For additional commands, e-mail: java-dev-help@lucene.apache.org
> >>
> >>
> >
> >
> > --
> > - Mark
> >
> > http://www.lucidimagination.com
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: java-dev-help@lucene.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
Re: Java 5 creeped again to Benchmark?
Posted by Michael McCandless <lu...@mikemccandless.com>.
I could go for that as well :)
Mike
On Thu, Aug 13, 2009 at 12:02 PM, Mark Miller<ma...@gmail.com> wrote:
> I'd almost just say Benchmark is 1.5 now. We try to keep contrib things that
> are 1.4 at 1.4, but why bend over backwards here to pull that task out?
> Technically there is no back compat promise here.
>
> The number of people relying on 1.4 for Benchmark has got to be ...
>
>
> Michael McCandless wrote:
>>
>> Sigh. I guess we have to pull that task for 2.9.
>>
>> I'll reopen the original issue (LUCENE-1773), note this, and mark it
>> as fix for 3.0.
>>
>> Mike
>>
>> On Thu, Aug 13, 2009 at 11:24 AM, Shai Erera<se...@gmail.com> wrote:
>>
>>>
>>> Me too ... and you were suggesting to hold off w/ 3.0 and having 2.5 and
>>> then 2.9 ... :).
>>>
>>> What do you think I should do w/ that task in the meantime?
>>>
>>> Shai
>>>
>>> On Thu, Aug 13, 2009 at 6:21 PM, Grant Ingersoll <gs...@apache.org>
>>> wrote:
>>>
>>>>
>>>> I _so_ can't wait to have this one off of our back for a while. Of
>>>> course, then we'll have 1.6 creep... ;-)
>>>>
>>>> On Aug 13, 2009, at 9:15 AM, Shai Erera wrote:
>>>>
>>>>
>>>>>
>>>>> I up SVN and noticed some compilation errors in my eclipse in
>>>>> SearchTravRetVectorHighlightTask. I added FastVectorHighlighter to my
>>>>> build
>>>>> path, but it failed again because the latter is Java 1.5 compliant, and
>>>>> I
>>>>> set the compiler level to 1.4 (to comply w/ core and benchmark level).
>>>>>
>>>>> Maybe this task should be put aside until we upgrade benchmark to 1.5?
>>>>>
>>>>> Shai
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>>
>>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>
>
> --
> - Mark
>
> http://www.lucidimagination.com
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Java 5 creeped again to Benchmark?
Posted by Mark Miller <ma...@gmail.com>.
And further - it makes sense that Benchmark would work with contrib
modules and contrib allows 1.5 ...
Mark Miller wrote:
> I'd almost just say Benchmark is 1.5 now. We try to keep contrib
> things that are 1.4 at 1.4, but why bend over backwards here to pull
> that task out? Technically there is no back compat promise here.
>
> The number of people relying on 1.4 for Benchmark has got to be ...
>
>
> Michael McCandless wrote:
>> Sigh. I guess we have to pull that task for 2.9.
>>
>> I'll reopen the original issue (LUCENE-1773), note this, and mark it
>> as fix for 3.0.
>>
>> Mike
>>
>> On Thu, Aug 13, 2009 at 11:24 AM, Shai Erera<se...@gmail.com> wrote:
>>
>>> Me too ... and you were suggesting to hold off w/ 3.0 and having 2.5
>>> and
>>> then 2.9 ... :).
>>>
>>> What do you think I should do w/ that task in the meantime?
>>>
>>> Shai
>>>
>>> On Thu, Aug 13, 2009 at 6:21 PM, Grant Ingersoll <gs...@apache.org>
>>> wrote:
>>>
>>>> I _so_ can't wait to have this one off of our back for a while. Of
>>>> course, then we'll have 1.6 creep... ;-)
>>>>
>>>> On Aug 13, 2009, at 9:15 AM, Shai Erera wrote:
>>>>
>>>>
>>>>> I up SVN and noticed some compilation errors in my eclipse in
>>>>> SearchTravRetVectorHighlightTask. I added FastVectorHighlighter to
>>>>> my build
>>>>> path, but it failed again because the latter is Java 1.5
>>>>> compliant, and I
>>>>> set the compiler level to 1.4 (to comply w/ core and benchmark
>>>>> level).
>>>>>
>>>>> Maybe this task should be put aside until we upgrade benchmark to
>>>>> 1.5?
>>>>>
>>>>> Shai
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>>
>>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>
>
--
- Mark
http://www.lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Java 5 creeped again to Benchmark?
Posted by Mark Miller <ma...@gmail.com>.
I'd almost just say Benchmark is 1.5 now. We try to keep contrib things
that are 1.4 at 1.4, but why bend over backwards here to pull that task
out? Technically there is no back compat promise here.
The number of people relying on 1.4 for Benchmark has got to be ...
Michael McCandless wrote:
> Sigh. I guess we have to pull that task for 2.9.
>
> I'll reopen the original issue (LUCENE-1773), note this, and mark it
> as fix for 3.0.
>
> Mike
>
> On Thu, Aug 13, 2009 at 11:24 AM, Shai Erera<se...@gmail.com> wrote:
>
>> Me too ... and you were suggesting to hold off w/ 3.0 and having 2.5 and
>> then 2.9 ... :).
>>
>> What do you think I should do w/ that task in the meantime?
>>
>> Shai
>>
>> On Thu, Aug 13, 2009 at 6:21 PM, Grant Ingersoll <gs...@apache.org>
>> wrote:
>>
>>> I _so_ can't wait to have this one off of our back for a while. Of
>>> course, then we'll have 1.6 creep... ;-)
>>>
>>> On Aug 13, 2009, at 9:15 AM, Shai Erera wrote:
>>>
>>>
>>>> I up SVN and noticed some compilation errors in my eclipse in
>>>> SearchTravRetVectorHighlightTask. I added FastVectorHighlighter to my build
>>>> path, but it failed again because the latter is Java 1.5 compliant, and I
>>>> set the compiler level to 1.4 (to comply w/ core and benchmark level).
>>>>
>>>> Maybe this task should be put aside until we upgrade benchmark to 1.5?
>>>>
>>>> Shai
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>
>>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
--
- Mark
http://www.lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Java 5 creeped again to Benchmark?
Posted by Shai Erera <se...@gmail.com>.
Thanks Mike. I wouldn't mind doing it myself, but since you already reopened
... ;)
On Thu, Aug 13, 2009 at 6:56 PM, Michael McCandless <
lucene@mikemccandless.com> wrote:
> Sigh. I guess we have to pull that task for 2.9.
>
> I'll reopen the original issue (LUCENE-1773), note this, and mark it
> as fix for 3.0.
>
> Mike
>
> On Thu, Aug 13, 2009 at 11:24 AM, Shai Erera<se...@gmail.com> wrote:
> > Me too ... and you were suggesting to hold off w/ 3.0 and having 2.5 and
> > then 2.9 ... :).
> >
> > What do you think I should do w/ that task in the meantime?
> >
> > Shai
> >
> > On Thu, Aug 13, 2009 at 6:21 PM, Grant Ingersoll <gs...@apache.org>
> > wrote:
> >>
> >> I _so_ can't wait to have this one off of our back for a while. Of
> >> course, then we'll have 1.6 creep... ;-)
> >>
> >> On Aug 13, 2009, at 9:15 AM, Shai Erera wrote:
> >>
> >>> I up SVN and noticed some compilation errors in my eclipse in
> >>> SearchTravRetVectorHighlightTask. I added FastVectorHighlighter to my
> build
> >>> path, but it failed again because the latter is Java 1.5 compliant, and
> I
> >>> set the compiler level to 1.4 (to comply w/ core and benchmark level).
> >>>
> >>> Maybe this task should be put aside until we upgrade benchmark to 1.5?
> >>>
> >>> Shai
> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> >> For additional commands, e-mail: java-dev-help@lucene.apache.org
> >>
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
Re: Java 5 creeped again to Benchmark?
Posted by Michael McCandless <lu...@mikemccandless.com>.
Sigh. I guess we have to pull that task for 2.9.
I'll reopen the original issue (LUCENE-1773), note this, and mark it
as fix for 3.0.
Mike
On Thu, Aug 13, 2009 at 11:24 AM, Shai Erera<se...@gmail.com> wrote:
> Me too ... and you were suggesting to hold off w/ 3.0 and having 2.5 and
> then 2.9 ... :).
>
> What do you think I should do w/ that task in the meantime?
>
> Shai
>
> On Thu, Aug 13, 2009 at 6:21 PM, Grant Ingersoll <gs...@apache.org>
> wrote:
>>
>> I _so_ can't wait to have this one off of our back for a while. Of
>> course, then we'll have 1.6 creep... ;-)
>>
>> On Aug 13, 2009, at 9:15 AM, Shai Erera wrote:
>>
>>> I up SVN and noticed some compilation errors in my eclipse in
>>> SearchTravRetVectorHighlightTask. I added FastVectorHighlighter to my build
>>> path, but it failed again because the latter is Java 1.5 compliant, and I
>>> set the compiler level to 1.4 (to comply w/ core and benchmark level).
>>>
>>> Maybe this task should be put aside until we upgrade benchmark to 1.5?
>>>
>>> Shai
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: Java 5 creeped again to Benchmark?
Posted by Shai Erera <se...@gmail.com>.
Me too ... and you were suggesting to hold off w/ 3.0 and having 2.5 and
then 2.9 ... :).
What do you think I should do w/ that task in the meantime?
Shai
On Thu, Aug 13, 2009 at 6:21 PM, Grant Ingersoll <gs...@apache.org>wrote:
> I _so_ can't wait to have this one off of our back for a while. Of course,
> then we'll have 1.6 creep... ;-)
>
>
> On Aug 13, 2009, at 9:15 AM, Shai Erera wrote:
>
> I up SVN and noticed some compilation errors in my eclipse in
>> SearchTravRetVectorHighlightTask. I added FastVectorHighlighter to my build
>> path, but it failed again because the latter is Java 1.5 compliant, and I
>> set the compiler level to 1.4 (to comply w/ core and benchmark level).
>>
>> Maybe this task should be put aside until we upgrade benchmark to 1.5?
>>
>> Shai
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
Re: Java 5 creeped again to Benchmark?
Posted by Grant Ingersoll <gs...@apache.org>.
I _so_ can't wait to have this one off of our back for a while. Of
course, then we'll have 1.6 creep... ;-)
On Aug 13, 2009, at 9:15 AM, Shai Erera wrote:
> I up SVN and noticed some compilation errors in my eclipse in
> SearchTravRetVectorHighlightTask. I added FastVectorHighlighter to
> my build path, but it failed again because the latter is Java 1.5
> compliant, and I set the compiler level to 1.4 (to comply w/ core
> and benchmark level).
>
> Maybe this task should be put aside until we upgrade benchmark to 1.5?
>
> Shai
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org