You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/21 15:15:54 UTC

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #726: LOG4J2-3358: Fix substitutions when the DefaultConfiguraiton is used

carterkozak commented on a change in pull request #726:
URL: https://github.com/apache/logging-log4j2/pull/726#discussion_r789743264



##########
File path: log4j-core/src/test/java/org/apache/logging/log4j/core/layout/JsonLayoutTest.java
##########
@@ -604,6 +608,37 @@ public void testEmptyValuesAreIgnored() {
         assertFalse(str, str.contains("\"empty\""));
     }
 
+    @Test // LOG4J2-3358
+    public void jsonLayout_should_substitute_lookups() {

Review comment:
       Structure borrowed from the test above: https://github.com/apache/logging-log4j2/blob/e7af4e0a1ead739598a5ca96d09bc214b68cf0ec/log4j-core/src/test/java/org/apache/logging/log4j/core/layout/JsonLayoutTest.java#L598-L599
   
   Happy to change both




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org