[jira] [Commented] (KAFKA-15556) Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect

["tangjiafu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778085#comment-17778085 ] 

tangjiafu commented on KAFKA-15556:
-----------------------------------

I am a novice, and this issue seems to involve checking the relevant code and deleting it. Can I give it a try? It would be even better if you could give me some guidance. thanks

> Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect
> -----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-15556
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15556
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: clients, consumer
>            Reporter: Kirk True
>            Priority: Major
>              Labels: consumer-threading-refactor, kip-848-preview
>
> The "new consumer" (i.e. {{{}PrototypeAsyncConsumer{}}}) was designed to handle networking details in a more centralized way. However, in order to reuse code between the existing {{KafkaConsumer}} and the new {{{}PrototypeAsyncConsumer{}}}, that design goal was "relaxed" when the {{NetworkClientDelegate}} capitulated and -stole- copied three methods from {{ConsumerNetworkClient}} related to detecting node status:
>  # {{isUnavailable}}
>  # {{maybeThrowAuthFailure}}
>  # {{tryConnect}}
> Unfortunately, these have found their way into the {{FetchRequestManager}} and {{OffsetsRequestManager}} implementations. We should review if we can clean up—or even remove—this leaky abstraction.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)