You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/27 01:22:41 UTC

[GitHub] [iceberg] aokolnychyi commented on pull request #5317: unit test should always verify mock invocation

aokolnychyi commented on PR #5317:
URL: https://github.com/apache/iceberg/pull/5317#issuecomment-1196164678

   @RussellSpitzer @abmo-x, we have started seeing test failures in affected tests. Could you help investigate?
   
   ```
   org.apache.iceberg.aws.s3.TestS3OutputStream > testAbortAfterFailedPartUpload FAILED
   [213](https://github.com/apache/iceberg/runs/7530666701?check_suite_focus=true#step:6:214)
       java.lang.AssertionError: 
   [214](https://github.com/apache/iceberg/runs/7530666701?check_suite_focus=true#step:6:215)
       Expecting throwable message:
   [215](https://github.com/apache/iceberg/runs/7530666701?check_suite_focus=true#step:6:216)
         "java.io.UncheckedIOException: java.nio.file.NoSuchFileException: /tmp/s3fileio-test-3731532446800745900/s3fileio-2448969152692915450.tmp"
   [216](https://github.com/apache/iceberg/runs/7530666701?check_suite_focus=true#step:6:217)
       to contain:
   [217](https://github.com/apache/iceberg/runs/7530666701?check_suite_focus=true#step:6:218)
         "mock uploadPart failure"
   [218](https://github.com/apache/iceberg/runs/7530666701?check_suite_focus=true#step:6:219)
       but did not.
   [219](https://github.com/apache/iceberg/runs/7530666701?check_suite_focus=true#step:6:220)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org