[GitHub] [druid] somu-imply commented on a change in pull request #12254: Adding vectorized time_shift

[GitBox <gi...@apache.org>]

somu-imply commented on a change in pull request #12254:
URL: https://github.com/apache/druid/pull/12254#discussion_r804076649



##########
File path: processing/src/main/java/org/apache/druid/query/expression/TimestampShiftExprMacro.java
##########
@@ -109,7 +113,33 @@ public ExprEval eval(final ObjectBinding bindings)
     @Override
     public Expr visit(Shuttle shuttle)
     {
-      return shuttle.visit(new TimestampShiftExpr(shuttle.visitAll(args)));
+      List<Expr> newArgs = args.stream().map(x -> x.visit(shuttle)).collect(Collectors.toList());
+      return shuttle.visit(new TimestampShiftExpr(newArgs));

Review comment:
       reverted

##########
File path: processing/src/main/java/org/apache/druid/query/expression/TimestampShiftExprMacro.java
##########
@@ -144,7 +174,8 @@ public ExprEval eval(final ObjectBinding bindings)
     @Override
     public Expr visit(Shuttle shuttle)
     {
-      return shuttle.visit(new TimestampShiftDynamicExpr(shuttle.visitAll(args)));
+      List<Expr> newArgs = args.stream().map(x -> x.visit(shuttle)).collect(Collectors.toList());
+      return shuttle.visit(new TimestampShiftDynamicExpr(newArgs));

Review comment:
       reverted




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org