You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/01/11 11:53:06 UTC

Review Request 55420: Added unit tests for nested container neglected runtime argv.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55420/
-----------------------------------------------------------

Review request for mesos, Avinash sridharan, Artem Harutyunyan, and Jie Yu.


Bugs: MESOS-6852
    https://issues.apache.org/jira/browse/MESOS-6852


Repository: mesos


Description
-------

These are regression tests for MESOS-6852. This patch includes
the tests for default image entrypoint or cmd with user defined
arguments appended for nested container case.


Diffs
-----

  src/tests/containerizer/runtime_isolator_tests.cpp c0c11607024b6a80d5bf5a486b91f7905a9083d7 

Diff: https://reviews.apache.org/r/55420/diff/


Testing
-------

make check


Thanks,

Gilbert Song


Re: Review Request 55420: Added unit tests for nested container neglected runtime argv.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55420/#review161268
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Jan. 11, 2017, 11:53 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55420/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2017, 11:53 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, and Jie Yu.
> 
> 
> Bugs: MESOS-6852
>     https://issues.apache.org/jira/browse/MESOS-6852
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These are regression tests for MESOS-6852. This patch includes
> the tests for default image entrypoint or cmd with user defined
> arguments appended for nested container case.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/runtime_isolator_tests.cpp c0c11607024b6a80d5bf5a486b91f7905a9083d7 
> 
> Diff: https://reviews.apache.org/r/55420/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>