You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2021/10/09 22:06:28 UTC

[GitHub] [openmeetings] sebawagner commented on a change in pull request #162: OPENMEETINGS-2684, OPENMEETINGS-2280 Apply viewport and fix height to adjust when resizing occurs for iOS/Mobile browsers

sebawagner commented on a change in pull request #162:
URL: https://github.com/apache/openmeetings/pull/162#discussion_r725542445



##########
File path: openmeetings-web/src/main/front/main/src/index.js
##########
@@ -20,3 +20,10 @@ Object.assign(window, {
 		$('#busy-indicator').hide();
 	}
 });
+function _updateResize() {
+	const doc = document.documentElement
+    doc.style.setProperty('--app-height', `${window.innerHeight}px`)

Review comment:
       This is a fix to adjust the height on iOS and mobile devices when the URL/navigation bar is hidden. Otherwise 100% will still show a white bar under the <body></body> because 100% on a mobile browser is assuming the URL/navigation bar of the browser is visible.
   
   This is particular annoying if on a mobile browser in landscape mode as it reduces the screen size by 10-20%.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org