You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/08/10 06:25:06 UTC
[GitHub] zeppelin pull request #1311: [ZEPPELIN-1316]
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1311
[ZEPPELIN-1316]
### What is this PR for?
If there are problems with the information defined in the Interpreter Setting (conf / interpreter.json), Interpreter Group during the defined file does not exist, can not run Zeppelin.
Thus, it was an exception handling for that part.
In order to address this issue in the current version it was restarted after deleting Interpreter.json.
### What type of PR is it?
Bug Fix
### Todos
- [x] - check to Interpreter Setting is null
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1316
### How should this be tested?
1. Modify the following part of the Interpreter.json file.
```json
{
"interpreterGroup": [
{
"name": "spark",
"class": "fake and invalid class path more more...", // invalid value
"defaultInterpreter": false
}
}
```
2.
After restarting the Zeppelin, Zeppelin Confirm that normally works.
Version of the PR is to be normally started up.
It should also be display all possible Interpreter Web UI.
### Screenshots (if appropriate)
#### before
<img width="618" alt="error" src="https://cloud.githubusercontent.com/assets/10525473/17543783/104363e4-5f0e-11e6-8279-e018a708ccb8.png">
#### after
<img width="1026" alt="correct" src="https://cloud.githubusercontent.com/assets/10525473/17543867/899da484-5f0e-11e6-9f8b-b1bac7cb2718.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-1316
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1311.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1311
----
commit d22358b6152e533473c0429c6942f28fe88884c5
Author: CloverHearts <cl...@gmail.com>
Date: 2016-08-10T05:58:39Z
check to Interpreter Setting is null on interpreter factory in loadfromfile method
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1311: [ZEPPELIN-1316] Zeppelin can not start due to an incor...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1311
This will ignore non-exist setting if it doesn't exist anymore in `interpreter/*`. I think it looks realistic in production level because admin usually delete that interpreter setting if it doesn't exists. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1311: [ZEPPELIN-1316] Zeppelin can not start due to an incor...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1311
Thank you @cloverhearts ! That happened to me as well.
Looks great to me.
\cc @jongyoul for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1311: [ZEPPELIN-1316] Zeppelin can not start due to an incor...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1311
@cloverhearts Thanks for the patch! I faced this wired 503 error several times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1311: [ZEPPELIN-1316] Zeppelin can not start due to an incor...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1311
CI is green now, so merging it in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1311: [ZEPPELIN-1316] Zeppelin can not start due to a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1311
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1311: [ZEPPELIN-1316] Zeppelin can not start due to an incor...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1311
Thank you for prompt review!
Merging _to master_ if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---