You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Richard Ding (JIRA)" <ji...@apache.org> on 2010/08/10 22:16:17 UTC

[jira] Created: (PIG-1541) FR Join shouldn't match null values

FR Join shouldn't match null values
-----------------------------------

                 Key: PIG-1541
                 URL: https://issues.apache.org/jira/browse/PIG-1541
             Project: Pig
          Issue Type: Bug
    Affects Versions: 0.7.0
            Reporter: Richard Ding
            Assignee: Richard Ding
             Fix For: 0.8.0



Here is an example:

Data input:

{code}
1       1
        2
{code}

the script 

{code}
a = load 'input';
b = load 'input';
c = join a by $0, b by $0 using 'repl';
dump c; 
{code}

generates results that matches null values:

{code}
(1,1,1,1)
(,2,,2)
{code}

The regular join, on the other hand, gives the correct results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1541) FR Join shouldn't match null values

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1541:
------------------------------

    Attachment: PIG-1541.patch

> FR Join shouldn't match null values
> -----------------------------------
>
>                 Key: PIG-1541
>                 URL: https://issues.apache.org/jira/browse/PIG-1541
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1541.patch
>
>
> Here is an example:
> Data input:
> {code}
> 1       1
>         2
> {code}
> the script 
> {code}
> a = load 'input';
> b = load 'input';
> c = join a by $0, b by $0 using 'repl';
> dump c; 
> {code}
> generates results that matches null values:
> {code}
> (1,1,1,1)
> (,2,,2)
> {code}
> The regular join, on the other hand, gives the correct results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1541) FR Join shouldn't match null values

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1541:
------------------------------

          Status: Resolved  (was: Patch Available)
    Hadoop Flags: [Reviewed]
      Resolution: Fixed

Tests are successful. The patch is committed to the trunk. 

> FR Join shouldn't match null values
> -----------------------------------
>
>                 Key: PIG-1541
>                 URL: https://issues.apache.org/jira/browse/PIG-1541
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1541.patch, PIG-1541_1.patch
>
>
> Here is an example:
> Data input:
> {code}
> 1       1
>         2
> {code}
> the script 
> {code}
> a = load 'input';
> b = load 'input';
> c = join a by $0, b by $0 using 'repl';
> dump c; 
> {code}
> generates results that matches null values:
> {code}
> (1,1,1,1)
> (,2,,2)
> {code}
> The regular join, on the other hand, gives the correct results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1541) FR Join shouldn't match null values

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1541:
------------------------------

    Status: Patch Available  (was: Open)

> FR Join shouldn't match null values
> -----------------------------------
>
>                 Key: PIG-1541
>                 URL: https://issues.apache.org/jira/browse/PIG-1541
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1541.patch
>
>
> Here is an example:
> Data input:
> {code}
> 1       1
>         2
> {code}
> the script 
> {code}
> a = load 'input';
> b = load 'input';
> c = join a by $0, b by $0 using 'repl';
> dump c; 
> {code}
> generates results that matches null values:
> {code}
> (1,1,1,1)
> (,2,,2)
> {code}
> The regular join, on the other hand, gives the correct results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1541) FR Join shouldn't match null values

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897866#action_12897866 ] 

Richard Ding commented on PIG-1541:
-----------------------------------


Results of test-patch:

{code}
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to i
     [exec] nclude 6 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
{code}

> FR Join shouldn't match null values
> -----------------------------------
>
>                 Key: PIG-1541
>                 URL: https://issues.apache.org/jira/browse/PIG-1541
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1541.patch
>
>
> Here is an example:
> Data input:
> {code}
> 1       1
>         2
> {code}
> the script 
> {code}
> a = load 'input';
> b = load 'input';
> c = join a by $0, b by $0 using 'repl';
> dump c; 
> {code}
> generates results that matches null values:
> {code}
> (1,1,1,1)
> (,2,,2)
> {code}
> The regular join, on the other hand, gives the correct results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1541) FR Join shouldn't match null values

Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898403#action_12898403 ] 

Thejas M Nair commented on PIG-1541:
------------------------------------

+1 , please commit if tests are successful.


> FR Join shouldn't match null values
> -----------------------------------
>
>                 Key: PIG-1541
>                 URL: https://issues.apache.org/jira/browse/PIG-1541
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1541.patch, PIG-1541_1.patch
>
>
> Here is an example:
> Data input:
> {code}
> 1       1
>         2
> {code}
> the script 
> {code}
> a = load 'input';
> b = load 'input';
> c = join a by $0, b by $0 using 'repl';
> dump c; 
> {code}
> generates results that matches null values:
> {code}
> (1,1,1,1)
> (,2,,2)
> {code}
> The regular join, on the other hand, gives the correct results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1541) FR Join shouldn't match null values

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1541:
------------------------------

    Attachment: PIG-1541_1.patch

New patch to address the general case where the join key is tuple.

> FR Join shouldn't match null values
> -----------------------------------
>
>                 Key: PIG-1541
>                 URL: https://issues.apache.org/jira/browse/PIG-1541
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.8.0
>
>         Attachments: PIG-1541.patch, PIG-1541_1.patch
>
>
> Here is an example:
> Data input:
> {code}
> 1       1
>         2
> {code}
> the script 
> {code}
> a = load 'input';
> b = load 'input';
> c = join a by $0, b by $0 using 'repl';
> dump c; 
> {code}
> generates results that matches null values:
> {code}
> (1,1,1,1)
> (,2,,2)
> {code}
> The regular join, on the other hand, gives the correct results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.