You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2020/12/09 21:03:16 UTC
svn commit: r1884270 -
/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFPictureData.java
Author: fanningpj
Date: Wed Dec 9 21:03:15 2020
New Revision: 1884270
URL: http://svn.apache.org/viewvc?rev=1884270&view=rev
Log:
[bug-64972] HSSFPictureData#getPictureType() should return 0 for unknown picture type (to be consistent with other implementations)
Modified:
poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFPictureData.java
Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFPictureData.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFPictureData.java?rev=1884270&r1=1884269&r2=1884270&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFPictureData.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFPictureData.java Wed Dec 9 21:03:15 2020
@@ -121,7 +121,8 @@ public class HSSFPictureData implements
}
/**
- * @return the POI internal image type, -1 if not unknown image type
+ * @return the POI internal image type, 0 if not unknown image type (was -1 prior to 5.0.0 but
+ * that was inconsistent with other {@link PictureData} implementations)
*
* @see Workbook#PICTURE_TYPE_DIB
* @see Workbook#PICTURE_TYPE_EMF
@@ -145,7 +146,7 @@ public class HSSFPictureData implements
case BLIP_DIB:
return Workbook.PICTURE_TYPE_DIB;
default:
- return -1;
+ return 0;
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org