You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2026/09/10 15:10:24 UTC

(skywalking-horizon-ui) branch feat/genai-evaluation-records updated: chore(e2e): note that the spring-ai build is a stopgap until apache/skywalking publishes the sample image

This is an automated email from the ASF dual-hosted git repository.

wu-sheng pushed a commit to branch feat/genai-evaluation-records
in repository https://gitbox.apache.org/repos/asf/skywalking-horizon-ui.git


The following commit(s) were added to refs/heads/feat/genai-evaluation-records by this push:
     new b46d4832 chore(e2e): note that the spring-ai build is a stopgap until apache/skywalking publishes the sample image
b46d4832 is described below

commit b46d48321e6b4642dc0b4e50bd2fb462930612d1
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Thu Sep 10 23:10:16 2026 +0800

    chore(e2e): note that the spring-ai build is a stopgap until apache/skywalking publishes the sample image
---
 test/e2e/script/Dockerfile.spring-ai | 8 +++++---
 test/e2e/script/env                  | 6 ++++--
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/test/e2e/script/Dockerfile.spring-ai b/test/e2e/script/Dockerfile.spring-ai
index c2d2c183..bcf02e12 100644
--- a/test/e2e/script/Dockerfile.spring-ai
+++ b/test/e2e/script/Dockerfile.spring-ai
@@ -19,9 +19,11 @@
 # openai-streaming-response sample, instrumented by the agent's spring-ai
 # plugin, so its LLM calls reach OAP as NATIVE GenAI spans.
 #
-# Built from a checkout, unlike every other fixture, because nobody publishes
-# the sample as an image — this is the same build apache/skywalking's own
-# virtual-genai case performs. Only the genai case builds it.
+# Built from a checkout, unlike every other fixture, because the sample is not
+# published as an image yet — this is the same build apache/skywalking's own
+# virtual-genai case performs. apache/skywalking is publishing it; once that
+# image exists, the genai compose pins it like the demo services and this file
+# goes. Only the genai case builds it.
 
 ARG SW_AGENT_JAVA_COMMIT
 ARG SW_AGENT_JDK_VERSION
diff --git a/test/e2e/script/env b/test/e2e/script/env
index cebfcfcf..b6b295ba 100644
--- a/test/e2e/script/env
+++ b/test/e2e/script/env
@@ -69,8 +69,10 @@ SW_AGENT_JDK_VERSION=17
 SW_E2E_SERVICE_COMMIT=9ae0b8d3941030a192c6a194f773850de1d4cd5e
 
 # spring-ai-examples, the sample the Java agent's spring-ai plugin instruments
-# in the genai case. Nobody publishes it as an image, so compose builds it at
-# this commit — the same one apache/skywalking's virtual-genai case checks out.
+# in the genai case. Built by compose at this commit (the one
+# apache/skywalking's virtual-genai case checks out) until apache/skywalking
+# publishes the sample as an image; then this becomes an image pin like the
+# demo services above and Dockerfile.spring-ai goes.
 SPRING_AI_EXAMPLES_COMMIT=2a6088db3d18d5fa6fc208b12adf1172d22f77fd
 
 # swctl, the project's own CLI — used for the fixture sanity check that asks