You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Christian Kunz (JIRA)" <ji...@apache.org> on 2007/07/10 04:35:04 UTC

[jira] Created: (HADOOP-1582) hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.

hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.
--------------------------------------------------------------------

                 Key: HADOOP-1582
                 URL: https://issues.apache.org/jira/browse/HADOOP-1582
             Project: Hadoop
          Issue Type: Improvement
            Reporter: Christian Kunz


As a C interface library, libhdfs should rather follow C-library conventions than Java convention, i.e. read functions should return 0 at end-of-file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1582) hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512049 ] 

Hudson commented on HADOOP-1582:
--------------------------------

Integrated in Hadoop-Nightly #152 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/152/])

> hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.
> --------------------------------------------------------------------
>
>                 Key: HADOOP-1582
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1582
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 0.14.0
>            Reporter: Christian Kunz
>            Assignee: Christian Kunz
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: libhdfs-read.patch
>
>
> As a C interface library, libhdfs should rather follow C-library conventions than Java convention, i.e. read functions should return 0 at end-of-file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1582) hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.

Posted by "Christian Kunz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Kunz updated HADOOP-1582:
-----------------------------------

    Attachment: libhdfs-read.patch

Attached patch.

> hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.
> --------------------------------------------------------------------
>
>                 Key: HADOOP-1582
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1582
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 0.14.0
>            Reporter: Christian Kunz
>            Priority: Minor
>         Attachments: libhdfs-read.patch
>
>
> As a C interface library, libhdfs should rather follow C-library conventions than Java convention, i.e. read functions should return 0 at end-of-file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1582) hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-1582:
----------------------------------

    Fix Version/s: 0.14.0
           Status: Patch Available  (was: Open)

> hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.
> --------------------------------------------------------------------
>
>                 Key: HADOOP-1582
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1582
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 0.14.0
>            Reporter: Christian Kunz
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: libhdfs-read.patch
>
>
> As a C interface library, libhdfs should rather follow C-library conventions than Java convention, i.e. read functions should return 0 at end-of-file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1582) hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated HADOOP-1582:
---------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed  this.  Thanks, Christian!

> hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.
> --------------------------------------------------------------------
>
>                 Key: HADOOP-1582
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1582
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 0.14.0
>            Reporter: Christian Kunz
>            Assignee: Christian Kunz
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: libhdfs-read.patch
>
>
> As a C interface library, libhdfs should rather follow C-library conventions than Java convention, i.e. read functions should return 0 at end-of-file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-1582) hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.

Posted by "Christian Kunz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Kunz updated HADOOP-1582:
-----------------------------------

          Component/s: libhdfs
             Priority: Minor  (was: Major)
    Affects Version/s: 0.14.0

> hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.
> --------------------------------------------------------------------
>
>                 Key: HADOOP-1582
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1582
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 0.14.0
>            Reporter: Christian Kunz
>            Priority: Minor
>
> As a C interface library, libhdfs should rather follow C-library conventions than Java convention, i.e. read functions should return 0 at end-of-file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1582) hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511527 ] 

Hadoop QA commented on HADOOP-1582:
-----------------------------------

+1

http://issues.apache.org/jira/secure/attachment/12361459/libhdfs-read.patch applied and successfully tested against trunk revision r554811.

Test results:   http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/390/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/390/console

> hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.
> --------------------------------------------------------------------
>
>                 Key: HADOOP-1582
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1582
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 0.14.0
>            Reporter: Christian Kunz
>            Assignee: Christian Kunz
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: libhdfs-read.patch
>
>
> As a C interface library, libhdfs should rather follow C-library conventions than Java convention, i.e. read functions should return 0 at end-of-file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-1582) hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511513 ] 

Arun C Murthy commented on HADOOP-1582:
---------------------------------------

+1 with caveat that this is a change to a 'public' api *smile*

> hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.
> --------------------------------------------------------------------
>
>                 Key: HADOOP-1582
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1582
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 0.14.0
>            Reporter: Christian Kunz
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: libhdfs-read.patch
>
>
> As a C interface library, libhdfs should rather follow C-library conventions than Java convention, i.e. read functions should return 0 at end-of-file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-1582) hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley reassigned HADOOP-1582:
-------------------------------------

    Assignee: Christian Kunz

> hdfsRead and hdfsPread should return 0 instead of -1 at end-of-file.
> --------------------------------------------------------------------
>
>                 Key: HADOOP-1582
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1582
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 0.14.0
>            Reporter: Christian Kunz
>            Assignee: Christian Kunz
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: libhdfs-read.patch
>
>
> As a C interface library, libhdfs should rather follow C-library conventions than Java convention, i.e. read functions should return 0 at end-of-file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.