You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "mjholub (via GitHub)" <gi...@apache.org> on 2024/01/11 16:14:23 UTC
[PR] docs(golang driver): add some comments for use with GoDoc [age]
mjholub opened a new pull request, #1504:
URL: https://github.com/apache/age/pull/1504
some formatting changes were made automatically with gofumpt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(golang driver): add some comments for use with GoDoc [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #1504:
URL: https://github.com/apache/age/pull/1504#issuecomment-1957791950
@mjholub Please fill out the _optional extended description_ with a brief (few lines) description of your changes. You will likely need to do this locally and force push it to your remote branch to update this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(golang driver): add some comments for use with GoDoc [age]
Posted by "mjholub (via GitHub)" <gi...@apache.org>.
mjholub commented on PR #1504:
URL: https://github.com/apache/age/pull/1504#issuecomment-1986693191
I'll take care of it soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(golang driver): add some comments for use with GoDoc [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #1504:
URL: https://github.com/apache/age/pull/1504#issuecomment-1972180159
@mjholub Can you please make the update so that I can merge the PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(golang driver): add some comments for use with GoDoc [age]
Posted by "mjholub (via GitHub)" <gi...@apache.org>.
mjholub commented on PR #1504:
URL: https://github.com/apache/age/pull/1504#issuecomment-1932799710
hmm perhaps writing examples could be more beneficial, made that PR because the driver felt somewhat confusing to me at first. see other database libraries on godoc for comparison, like pgx or go-sqlite3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(golang driver): add some comments for use with GoDoc [age]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #1504: docs(golang driver): add some comments for use with GoDoc
URL: https://github.com/apache/age/pull/1504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(golang driver): add some comments for use with GoDoc [age]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1504:
URL: https://github.com/apache/age/pull/1504#issuecomment-2119036148
This PR was closed because it has been stalled for further 7 days with no activity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(golang driver): add some comments for use with GoDoc [age]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1504:
URL: https://github.com/apache/age/pull/1504#issuecomment-2105396972
This PR is stale because it has been open 45 days with no activity. Remove "Abondoned" label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(golang driver): add some comments for use with GoDoc [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #1504:
URL: https://github.com/apache/age/pull/1504#issuecomment-1955647003
@mjholub You should be able to rebase your PR's local branch with the AGE master and then do a force push to your remote mjholub:go-driver-documentation branch. That will cause the PR to be updated and should restart all of the PR checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(golang driver): add some comments for use with GoDoc [age]
Posted by "mjholub (via GitHub)" <gi...@apache.org>.
mjholub commented on PR #1504:
URL: https://github.com/apache/age/pull/1504#issuecomment-1957483206
@jrgemignani yeah I know, it appears there are no conflicts though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(golang driver): add some comments for use with GoDoc [age]
Posted by "mjholub (via GitHub)" <gi...@apache.org>.
mjholub commented on PR #1504:
URL: https://github.com/apache/age/pull/1504#issuecomment-1934006140
Though if it may cause any merge conflict with anything that changes the codebase, please just merge the code changes first and then I'd happily rebase and remove any outdated comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org