You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/05/08 07:38:33 UTC
[kudu-CR] [easy json] a small cleanup on templated methods
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13280
Change subject: [easy_json] a small cleanup on templated methods
......................................................................
[easy_json] a small cleanup on templated methods
This is a small cleanup on the explicit instantiations of template
methods in EasyJson class. Relying on the deduction of the template
arguments by compiler, it's possible to remove some clatter there.
This patch contains no functional changes.
Change-Id: I7a735baaa2352d8572887e4bb764fb5382da2f92
---
M src/kudu/util/easy_json.cc
1 file changed, 35 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/13280/1
--
To view, visit http://gerrit.cloudera.org:8080/13280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a735baaa2352d8572887e4bb764fb5382da2f92
Gerrit-Change-Number: 13280
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [easy json] a small cleanup on templated methods
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13280
to look at the new patch set (#2).
Change subject: [easy_json] a small cleanup on templated methods
......................................................................
[easy_json] a small cleanup on templated methods
This is a small cleanup on the explicit instantiations of template
methods in EasyJson class. Relying on the deduction of the template
arguments by compiler, it's possible to reduce the clutter.
This patch contains no functional changes.
Change-Id: I7a735baaa2352d8572887e4bb764fb5382da2f92
---
M src/kudu/util/easy_json.cc
1 file changed, 35 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/13280/2
--
To view, visit http://gerrit.cloudera.org:8080/13280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a735baaa2352d8572887e4bb764fb5382da2f92
Gerrit-Change-Number: 13280
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [easy json] a small cleanup on templated methods
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13280 )
Change subject: [easy_json] a small cleanup on templated methods
......................................................................
Patch Set 1: Verified+1 -Code-Review
--
To view, visit http://gerrit.cloudera.org:8080/13280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a735baaa2352d8572887e4bb764fb5382da2f92
Gerrit-Change-Number: 13280
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 May 2019 15:27:03 +0000
Gerrit-HasComments: No
[kudu-CR] [easy json] a small cleanup on templated methods
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13280 )
Change subject: [easy_json] a small cleanup on templated methods
......................................................................
[easy_json] a small cleanup on templated methods
This is a small cleanup on the explicit instantiations of template
methods in EasyJson class. Relying on the deduction of the template
arguments by compiler, it's possible to reduce the clutter.
This patch contains no functional changes.
Change-Id: I7a735baaa2352d8572887e4bb764fb5382da2f92
Reviewed-on: http://gerrit.cloudera.org:8080/13280
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/util/easy_json.cc
1 file changed, 35 insertions(+), 38 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a735baaa2352d8572887e4bb764fb5382da2f92
Gerrit-Change-Number: 13280
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [easy json] a small cleanup on templated methods
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13280 )
Change subject: [easy_json] a small cleanup on templated methods
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13280/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13280/1//COMMIT_MSG@11
PS1, Line 11: clatter
Nit: I think you mean "chatter"? :)
--
To view, visit http://gerrit.cloudera.org:8080/13280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a735baaa2352d8572887e4bb764fb5382da2f92
Gerrit-Change-Number: 13280
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 May 2019 16:47:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] [easy json] a small cleanup on templated methods
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13280 )
Change subject: [easy_json] a small cleanup on templated methods
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I7a735baaa2352d8572887e4bb764fb5382da2f92
Gerrit-Change-Number: 13280
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] [easy json] a small cleanup on templated methods
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13280 )
Change subject: [easy_json] a small cleanup on templated methods
......................................................................
Patch Set 1: Code-Review+1
unrelated flake in KuduTest.TestWebUIDoesNotCrashCluster due to NTP issue
--
To view, visit http://gerrit.cloudera.org:8080/13280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a735baaa2352d8572887e4bb764fb5382da2f92
Gerrit-Change-Number: 13280
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 May 2019 15:26:56 +0000
Gerrit-HasComments: No
[kudu-CR] [easy json] a small cleanup on templated methods
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13280 )
Change subject: [easy_json] a small cleanup on templated methods
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13280/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13280/1//COMMIT_MSG@11
PS1, Line 11: clatter
> Nit: I think you mean "chatter"? :)
whoops, that's a typo
I meant "clutter" :)
Thank you for the review!
--
To view, visit http://gerrit.cloudera.org:8080/13280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a735baaa2352d8572887e4bb764fb5382da2f92
Gerrit-Change-Number: 13280
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 May 2019 17:58:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] [easy json] a small cleanup on templated methods
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13280 )
Change subject: [easy_json] a small cleanup on templated methods
......................................................................
Patch Set 2: Code-Review+2
Carrying over Adar's +2 from PS1
--
To view, visit http://gerrit.cloudera.org:8080/13280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a735baaa2352d8572887e4bb764fb5382da2f92
Gerrit-Change-Number: 13280
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 May 2019 18:21:52 +0000
Gerrit-HasComments: No