You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/23 06:14:15 UTC
[GitHub] [incubator-doris] gengjun-git opened a new pull request #3172:
Change some config
gengjun-git opened a new pull request #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172
1. Change word of palo to doris in conf file.
2. Set backend data path to ${DORIS_HOME}/doris-data by default, in order to start quickly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#3172: Change some config
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172#discussion_r396477824
##########
File path: conf/fe.conf
##########
@@ -38,7 +38,7 @@ JAVA_OPTS_FOR_JDK_9="-Xmx4096m -XX:SurvivorRatio=8 -XX:MaxTenuringThreshold=7 -X
sys_log_level = INFO
# store metadata, create it if it is not exist.
-meta_dir = ${DORIS_HOME}/palo-meta
Review comment:
How about change this to
```
# meta_dir = ${DORIS_HOME}/doris-meta
```
So that it is same as default value in `be.conf`, which is also commented out.
And we should also change this in FE's `config.java`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] gengjun-git commented on a change in pull request
#3172: Change some config
Posted by GitBox <gi...@apache.org>.
gengjun-git commented on a change in pull request #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172#discussion_r396883903
##########
File path: conf/fe.conf
##########
@@ -38,7 +38,7 @@ JAVA_OPTS_FOR_JDK_9="-Xmx4096m -XX:SurvivorRatio=8 -XX:MaxTenuringThreshold=7 -X
sys_log_level = INFO
# store metadata, create it if it is not exist.
-meta_dir = ${DORIS_HOME}/palo-meta
Review comment:
OK. I will change meta_dir and storage_root_path commented out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] gengjun-git commented on a change in pull request
#3172: Change some config
Posted by GitBox <gi...@apache.org>.
gengjun-git commented on a change in pull request #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172#discussion_r399157800
##########
File path: conf/be.conf
##########
@@ -36,15 +36,16 @@ brpc_port = 8060
# you can specify the storage medium of each root path, HDD or SSD
# you can add capacity limit at the end of each root path, seperate by ','
# eg:
-# storage_root_path = /home/disk1/palo.HDD,50;/home/disk2/palo.SSD,1;/home/disk2/palo
-# /home/disk1/palo.HDD, capacity limit is 50GB, HDD;
-# /home/disk2/palo.SSD, capacity limit is 1GB, SSD;
-# /home/disk2/palo, capacity limit is disk capacity, HDD(default)
+# storage_root_path = /home/disk1/doris.HDD,50;/home/disk2/doris.SSD,1;/home/disk2/doris
+# /home/disk1/doris.HDD, capacity limit is 50GB, HDD;
+# /home/disk2/doris.SSD, capacity limit is 1GB, SSD;
+# /home/disk2/doris, capacity limit is disk capacity, HDD(default)
#
# you also can specify the properties by setting '<property>:<value>', seperate by ','
# property 'medium' has a higher priority than the extension of path
-# storage_root_path = /home/disk1/palo,medium:ssd,capacity:50
-storage_root_path = /home/disk1/palo;/home/disk2/palo
+#
+# Default value is ${DORIS_HOME}/storage, you should create it by hand.
+# storage_root_path = ${DORIS_HOME}/storage
Review comment:
The default value in conf.cpp is already ${DORIS_HOME}/storage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#3172: Change some config
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172#discussion_r396303812
##########
File path: conf/fe.conf
##########
@@ -38,7 +38,7 @@ JAVA_OPTS_FOR_JDK_9="-Xmx4096m -XX:SurvivorRatio=8 -XX:MaxTenuringThreshold=7 -X
sys_log_level = INFO
# store metadata, create it if it is not exist.
-meta_dir = ${DORIS_HOME}/palo-meta
Review comment:
I am afraid this may cause some problem.
Some users may not notice this configuration and use the default `palo-meta` directory directly. When the cluster is upgraded, if it is replaced with the `doris-meta` directory, some problems may occur. This directory configuration recommendation remains unchanged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] gengjun-git commented on a change in pull request
#3172: Change some config
Posted by GitBox <gi...@apache.org>.
gengjun-git commented on a change in pull request #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172#discussion_r396884274
##########
File path: conf/fe.conf
##########
@@ -38,7 +38,7 @@ JAVA_OPTS_FOR_JDK_9="-Xmx4096m -XX:SurvivorRatio=8 -XX:MaxTenuringThreshold=7 -X
sys_log_level = INFO
# store metadata, create it if it is not exist.
-meta_dir = ${DORIS_HOME}/palo-meta
Review comment:
OK. I will make meta_dir and storage_root_path commented out, and leave the default value changed to doris.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #3172:
Change some config
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172#discussion_r396334687
##########
File path: conf/fe.conf
##########
@@ -38,7 +38,7 @@ JAVA_OPTS_FOR_JDK_9="-Xmx4096m -XX:SurvivorRatio=8 -XX:MaxTenuringThreshold=7 -X
sys_log_level = INFO
# store metadata, create it if it is not exist.
-meta_dir = ${DORIS_HOME}/palo-meta
Review comment:
Hi @morningman, for this change I don't agree with you.
1. configuration files will not be updated in normal case.
2. Even if he uses the new configure file, the FE will exit with error messages like "There is no meta directory". And this can be fixed by change this option to the correct directory.
In my opinion, code must keep compatible with old versions. However, configuration default value is unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #3172: Change some
config
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172#issuecomment-604979780
> If is necessary to change binary name from palo_be to doris_be, palo_fe to doris_fe ?
Maybe in another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #3172:
Change some config
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172#discussion_r396870848
##########
File path: conf/fe.conf
##########
@@ -38,7 +38,7 @@ JAVA_OPTS_FOR_JDK_9="-Xmx4096m -XX:SurvivorRatio=8 -XX:MaxTenuringThreshold=7 -X
sys_log_level = INFO
# store metadata, create it if it is not exist.
-meta_dir = ${DORIS_HOME}/palo-meta
Review comment:
It works for me.
Comment for this configuration should be recorded in this file carefully. And related documents and tutorials should be changed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #3172:
Change some config
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172#discussion_r398694002
##########
File path: conf/be.conf
##########
@@ -36,15 +36,16 @@ brpc_port = 8060
# you can specify the storage medium of each root path, HDD or SSD
# you can add capacity limit at the end of each root path, seperate by ','
# eg:
-# storage_root_path = /home/disk1/palo.HDD,50;/home/disk2/palo.SSD,1;/home/disk2/palo
-# /home/disk1/palo.HDD, capacity limit is 50GB, HDD;
-# /home/disk2/palo.SSD, capacity limit is 1GB, SSD;
-# /home/disk2/palo, capacity limit is disk capacity, HDD(default)
+# storage_root_path = /home/disk1/doris.HDD,50;/home/disk2/doris.SSD,1;/home/disk2/doris
+# /home/disk1/doris.HDD, capacity limit is 50GB, HDD;
+# /home/disk2/doris.SSD, capacity limit is 1GB, SSD;
+# /home/disk2/doris, capacity limit is disk capacity, HDD(default)
#
# you also can specify the properties by setting '<property>:<value>', seperate by ','
# property 'medium' has a higher priority than the extension of path
-# storage_root_path = /home/disk1/palo,medium:ssd,capacity:50
-storage_root_path = /home/disk1/palo;/home/disk2/palo
+#
+# Default value is ${DORIS_HOME}/storage, you should create it by hand.
+# storage_root_path = ${DORIS_HOME}/storage
Review comment:
be/src/common/conf.cpp should be changed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3172: Change some
config
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on issue #3172: Change some
config
Posted by GitBox <gi...@apache.org>.
chaoyli commented on issue #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172#issuecomment-602966317
If is necessary to change binary name from palo_be to doris_be, palo_fe to doris_fe ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] gengjun-git commented on a change in pull request
#3172: Change some config
Posted by GitBox <gi...@apache.org>.
gengjun-git commented on a change in pull request #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172#discussion_r396883903
##########
File path: conf/fe.conf
##########
@@ -38,7 +38,7 @@ JAVA_OPTS_FOR_JDK_9="-Xmx4096m -XX:SurvivorRatio=8 -XX:MaxTenuringThreshold=7 -X
sys_log_level = INFO
# store metadata, create it if it is not exist.
-meta_dir = ${DORIS_HOME}/palo-meta
Review comment:
OK. I will change meta_dir and storage_root_path commented out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org